From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [patch] two patchs about tab-bar.el Date: Fri, 10 Sep 2021 09:33:48 +0300 Organization: LINKOV.NET Message-ID: <87o8916jqb.fsf@mail.linkov.net> References: <79741d39.2e84.17bce00d409.Coremail.tumashu@163.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35764"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: "emacs-devel@gnu.org" To: tumashu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 10 08:46:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOaIS-0008yE-2X for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Sep 2021 08:46:00 +0200 Original-Received: from localhost ([::1]:48694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOaIQ-0006Js-87 for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Sep 2021 02:45:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOaGy-0004X6-8K for emacs-devel@gnu.org; Fri, 10 Sep 2021 02:44:28 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:36803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOaGw-0001cv-I4 for emacs-devel@gnu.org; Fri, 10 Sep 2021 02:44:28 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 839241C0008; Fri, 10 Sep 2021 06:44:21 +0000 (UTC) In-Reply-To: <79741d39.2e84.17bce00d409.Coremail.tumashu@163.com> (tumashu@163.com's message of "Fri, 10 Sep 2021 12:39:25 +0800 (CST)") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274498 Archived-At: > * lisp/tab-bar.el (tab-bar-get-buffer-tab): Fix issue when > 'current-tab is not at the beginning of tabs. > > --- a/lisp/tab-bar.el > +++ b/lisp/tab-bar.el > @@ -1940,7 +1940,9 @@ tab-bar-get-buffer-tab > - (funcall tab-bar-tabs-function frame))) > + (let ((tabs (funcall tab-bar-tabs-function frame))) > + ;; Make sure current-tab is alway at the beginning of tabs. > + (push (assq 'current-tab tabs) tabs)))) Please explain what problem this patch is intended to fix. > --- a/lisp/tab-bar.el > +++ b/lisp/tab-bar.el > @@ -1962,11 +1962,12 @@ display-buffer-in-tab > > If ALIST contains a `reusable-frames' entry, its value determines > which frames to search for a reusable tab: > - nil -- the selected frame (actually the last non-minibuffer frame) > + nil -- do not reuse any frames. > A frame -- just that frame > `visible' -- all visible frames > 0 -- all frames on the current terminal > t -- all frames. > + others -- selected frame. I wonder where did you get the value 'others' that means the selected frame?