From: Juri Linkov <juri@linkov.net>
To: tumashu <tumashu@163.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [patch] two patchs about tab-bar.el
Date: Fri, 10 Sep 2021 09:33:48 +0300 [thread overview]
Message-ID: <87o8916jqb.fsf@mail.linkov.net> (raw)
In-Reply-To: <79741d39.2e84.17bce00d409.Coremail.tumashu@163.com> (tumashu@163.com's message of "Fri, 10 Sep 2021 12:39:25 +0800 (CST)")
> * lisp/tab-bar.el (tab-bar-get-buffer-tab): Fix issue when
> 'current-tab is not at the beginning of tabs.
>
> --- a/lisp/tab-bar.el
> +++ b/lisp/tab-bar.el
> @@ -1940,7 +1940,9 @@ tab-bar-get-buffer-tab
> - (funcall tab-bar-tabs-function frame)))
> + (let ((tabs (funcall tab-bar-tabs-function frame)))
> + ;; Make sure current-tab is alway at the beginning of tabs.
> + (push (assq 'current-tab tabs) tabs))))
Please explain what problem this patch is intended to fix.
> --- a/lisp/tab-bar.el
> +++ b/lisp/tab-bar.el
> @@ -1962,11 +1962,12 @@ display-buffer-in-tab
>
> If ALIST contains a `reusable-frames' entry, its value determines
> which frames to search for a reusable tab:
> - nil -- the selected frame (actually the last non-minibuffer frame)
> + nil -- do not reuse any frames.
> A frame -- just that frame
> `visible' -- all visible frames
> 0 -- all frames on the current terminal
> t -- all frames.
> + others -- selected frame.
I wonder where did you get the value 'others' that means the selected frame?
next prev parent reply other threads:[~2021-09-10 6:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 4:39 [patch] two patchs about tab-bar.el tumashu
2021-09-10 6:33 ` Juri Linkov [this message]
2021-09-10 13:18 ` tumashu
2021-09-10 13:24 ` tumashu
2021-09-10 13:36 ` tumashu
2021-09-10 16:17 ` Juri Linkov
2021-09-10 18:33 ` tumashu
2021-09-12 7:03 ` Juri Linkov
2021-09-12 9:34 ` tumashu
2021-09-12 16:10 ` Juri Linkov
2021-09-10 23:48 ` Feng Shu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8916jqb.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=emacs-devel@gnu.org \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).