From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Patch: perform autoloading when docs is missing from autoload object Date: Fri, 17 Sep 2021 16:01:21 +0200 Message-ID: <87o88rxpvy.fsf@gnus.org> References: <87ee9o3cqj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 17 16:06:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mREVb-000764-DC for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Sep 2021 16:06:31 +0200 Original-Received: from localhost ([::1]:57964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mREVZ-0005AC-Ob for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Sep 2021 10:06:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mREQo-000241-Sq for emacs-devel@gnu.org; Fri, 17 Sep 2021 10:01:34 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:36880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mREQn-0004NX-AL for emacs-devel@gnu.org; Fri, 17 Sep 2021 10:01:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XniMTJsRupfDe18ghJEEEOsrHpf8lTu42QqOgaq/3Vw=; b=LbC1Uro25WtWipIviezm43OOY9 l6lcTy9HLlcfgNYSFN8pXDHi1YAt003ylzbDKs/icHrDQLYzT2BFq/kNz2l5CUEFFaZhOpKdwaoN6 oOsZdSCkfLU5qgz6FHX3Gwp1I634Z8ooRb6cLuVUwFRnVQM4m9gXgwx76Tl+WGMJIA6s=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mREQc-0000HC-9X; Fri, 17 Sep 2021 16:01:24 +0200 In-Reply-To: (Arthur Miller's message of "Fri, 17 Sep 2021 08:49:17 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274878 Archived-At: Arthur Miller writes: >> In which cases will this make a difference when displaying the *Help* >> buffer for the symbol? > > In case where the symbol is not loaded, and there is no doc entry in autoload > object. Oh, right --- I was thinking about ;;;###autoload, where the doc string is available always, not (autoload 'foo "foo") Yes, in those cases it would indeed be helpful if the help machinery just went ahead and loaded the library. However, there are some instances where loading a library has unexpected side effects, like enabling new modes and keymaps. Doing so is frowned upon (loading a library shouldn't do those things), but it happens. If this is a concern, then we could perhaps add a button to *Help* to do the loading instead of loading automatically? But perhaps just loading the file automatically would be fine anyway -- it's a bug for libraries to side-effect to an annoying degree upon load. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no