From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Splitting image-dired.el into smaller files Date: Thu, 09 Dec 2021 02:05:02 +0100 Message-ID: <87o85q4mgx.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35274"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Mathias Dahl , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 09 02:06:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mv7sq-0008uI-6t for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 02:06:04 +0100 Original-Received: from localhost ([::1]:40698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mv7sp-0002VB-7j for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Dec 2021 20:06:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv7s8-0001jT-Jr for emacs-devel@gnu.org; Wed, 08 Dec 2021 20:05:20 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=57364 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv7s6-0001lQ-Tg for emacs-devel@gnu.org; Wed, 08 Dec 2021 20:05:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MSxYc+/OQmLuLN3hkiw9bcNW8R+/9L/scmVIcpXH7aU=; b=qFwv4VWd9ViU9Rsgde3WJA5XRB TeAYiV8Cc5wuxk+tmvQtJa0DpZIlJ+Jck37dIE29A6D6Sh0IV5+jPBlZyBatAZ8rOPAL0qXJrCzIN 1YV/qPGhpFA6FcULEwltX1wZHTQ08hSZVkUZ5tRwMAMnLh6cNdtln+58BEGrAGeyvIzY=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mv7rx-0005Sq-Cc; Thu, 09 Dec 2021 02:05:12 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUtLT9Wcarq7/ai rsT///+j1o5LAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UMCQECAAFRiq8AAAGXSURBVDjLbZOLteQg CEBBG5CxgUQbEOm/t+UTNXlnmTkmcgMoH0CiAoDgQtRc+mxQRQo8UgirA4AJhISbIJWp+gsgmcUx UV9ZgfvOVOgAlQDh4POYreOyj/X5LrV7H8b1K1RuYxmYokoXdoIeAu2I9hTRi/q5sfm59U/uKB4P QBK7k724HmxVVwgLWL506wAm+2fhQl0y1EIW/3cfazVQb7+BXXepFwiLJ/P6pmewIHTDAr4Czc6W LemFDFCIsLTu0e96gGbfKuEg9YgOrn5qSp4t9pvCVrcmkRQnRcH8ACuJeKK3wR+AfwBFo3xA31sv 1YnR7cY0F6gvYHWrC+QN7r3/L0D6BQB5uXLFAicIoDWPhn9a6Ld9oRYRuS2A26TJ5CkbgHd9hHl8 vuRl9gWwAdUOwgyZryr3OcKw8nFScAlbM/1OJsEtRNKoHDlaNQHRX5+pjB737Gs6tLI8MoKMGJLP PK5pqzKOiuG+UuIArImtY4HB+QFZXDbII5WdFpH6lKKMfL0sKMa6foJnmTGLB8AGQtFR/wDlyU2n njvcHgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0xMi0wOVQwMTowMjowMCswMDowMA5/OOMAAAAl dEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTItMDlUMDE6MDI6MDArMDA6MDB/IoBfAAAAAElFTkSuQmCC X-Now-Playing: Peter Gabriel's _Plays Live (1)_: "D.I.Y." In-Reply-To: (Stefan Kangas's message of "Wed, 8 Dec 2021 13:50:09 -0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281418 Archived-At: Stefan Kangas writes: > My current best idea for improving its organization is to split it up in > several files along these lines: > > image/image-dired-bookmarks.el ;; bookmark.el support > image/image-dired-compat.el ;; compatibility layer > image/image-dired-gallery.el ;; HTML gallery generation > image/image-dired-tags.el ;; home-cooked image tags > image/image-dired-thumbs.el ;; thumbnail generation > image/image-dired.el > > The big drawback here is that we will lose the git history. However, we > lost most of that already in 2007 when the file was renamed. From my > work and what I've seen so far, I don't think I will miss any history > that won't be massively outweighed by the benefits of better code > organization. I think sounds like a good reorganisation, and image-dired could use some of that. (And like Stefan M said, the bookmark stuff seems small enough to just keep in image-dired.el.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no