From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 28.0.90 is out Date: Sat, 11 Dec 2021 09:06:26 +0800 Message-ID: <87o85o3q7h.fsf@yahoo.com> References: <838rwuukkx.fsf@gnu.org> <878rwuavr7.fsf@yahoo.com> <831r2mug6n.fsf@gnu.org> <83zgpat0di.fsf@gnu.org> <87v8zy9c4o.fsf@yahoo.com> <87r1am9bsz.fsf@yahoo.com> <83wnkesz7r.fsf@gnu.org> <87mtl9apcx.fsf@yahoo.com> <83v8zxucaz.fsf@gnu.org> <87ilvxao13.fsf@yahoo.com> <83r1alub0m.fsf@gnu.org> <83pmq5ua9p.fsf@gnu.org> <83o85pu9u0.fsf@gnu.org> <83mtl9u9c8.fsf@gnu.org> <87a6h99uk5.fsf@yahoo.com> <875yrx9tlo.fsf@yahoo.com> <831r2kua9o.fsf@gnu.org> <877dcc6bw7.fsf@yahoo.com> <87wnkc4lrj.fsf@yahoo.com> <83lf0ssfho.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 11 02:07:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvqrL-0002nX-GF for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Dec 2021 02:07:31 +0100 Original-Received: from localhost ([::1]:53786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvqrK-0005Xj-AA for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Dec 2021 20:07:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvqqT-0004qB-Qp for emacs-devel@gnu.org; Fri, 10 Dec 2021 20:06:37 -0500 Original-Received: from sonic311-25.consmr.mail.ne1.yahoo.com ([66.163.188.206]:37094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvqqR-0006uU-92 for emacs-devel@gnu.org; Fri, 10 Dec 2021 20:06:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639184794; bh=nzWWkprYjWeCof3ZoslvLqNRzZmQ+GUlMb4tY4inLgE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=B0bUXNlaUDwC6iLxorLXTPi4M3sCH95ADTe78Q48J63WY8fxflOv6ttVLJLHyMvG2HmBK9M9qHetynx4Ilj/QEwzviHwRoPmsWR1hNzY2wzhQKhJWCqhlv8fR8g6J1O4qgI741sGnNaIwJpGtjTLBkOop4iXpghWUMh0BUFoU6eAWlW6VT8mRTA1fe47Tk7CajtBI+sm26t/gk0MLM/WfREc7Rqb3h20tz1RTEeVWZeafT0WQsEXfvV9dfaaxi6h3m1Ir4RmG22R8z4bHnCggd3UolQItRZGCCElKr+z2W6F6fikc7zZGaPG2ksnk5o3+KetcVGZ6eM4WyTZLi0SBA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639184794; bh=x2i58ZsMhfO+90KHx8i1NtZOx0xwzywJbcMiEx18+/j=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PG1bsgWvY9H7By/b07VdTpX9S9kRWhj8E0SmtWAR8rTbtvwRTOuCQL82aa+KQBInNhDV5VPG8a513OjIzpa7X4TCDoEiswzbUTLBuFRIZvN3h6nqsm5/3P8aEJCDZhPolOTJiRXzX4WXDjN6rnoeIpN5Yl3BIuvE329OK95invAcLrkqCNWjtfF+fgJYtXIyy+M1NmiEOokal43gKr0u1irAffwih5uzEjWrxBpPgBMm7AO9yyl0mSJcZxF5UqtzljBV4f7a1fWvuD5Q1wNoF1KwUYyLN6vOHA4Mx5WooiMdq2yEhvJkJHW7lBM/tw1GWzz6V/w4FPbq+abCI7BsNg== X-YMail-OSG: lqU.caEVM1lzNSUgt0vnf6yNz_LoX0rk2U.PvG._653VmoH7UUaYHbeHIHa4xZ0 8cL1_EKN14Vaij1_qQNEjR8y6sHLu1vFujHTFUqDeFvTpIDYnSk85NgbUBf_ZgsvTCmTbnJ7nIFw F80oQeMr8Wt5iLdwhd7gvigkc2O6NP9owcMhJLQ5I7yrKrY3n87_hd18k6A1IGW6QK63HIjcfkGe byRCuiSq8nsrR4aVeVm8Dt3_xAQEUG07KRfxoUv6JdiyMvXvyNzfBWLX8yc48SmufV3PgR2kCRSP d3ULpVW6iSAHjZewCJ52MD7zNx2m5JWNxMUHgpG_rgxEJJLj1jnbDgw9c6srCHeJi07as6MGvNSp zlUB5Zj_BfTaq_gnfqladszdqKwhJye5sz0a_fBXm1AklX.ZbGP2tcT0nt6tNMNDij1ijLVd9nTA 4.hRgo9.jXDibPjk6Ip8cmzv__u820vkCBivZ8MxOdsYMP8G0zZAGeKZ_gK42wEuNrnw4M4HonAs qaXvnO.87E6VtHYgJHeW9IN26hZJGjZBzQtyD2hjZLX_4fpLhJD4qsCbZX7btRjFD.MzPOY7nV5P Tk_AtYKMkNMU.YlMwBOqo6NODYIABRmA1cKEB9EomltHw8TQGSJnXZ_tBG3kJclMtqLx5SBTCNrV k7Z5K6jYG20LOweFiSdP0UOL1xSTvx7cqo9gcKDTQf6.XykzeTUIMnAZ._7IhiAnOQ6a9BRvarHp wFDajdBcVl1swdemVC1L.m6YmWBziWfWPIUTHUAbgPKk86zuMILH8jx4.7RY5xlhHdVgsT0vrETi Q3u_ehwFiZlZDvlYHAWh7ybdQrLE.WeIzEzJrB5JMw X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Sat, 11 Dec 2021 01:06:34 +0000 Original-Received: by kubenode504.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b1a2b8f31932bf16a351e35c3f1e12fd; Sat, 11 Dec 2021 01:06:31 +0000 (UTC) In-Reply-To: <83lf0ssfho.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Dec 2021 16:26:27 +0200") X-Mailer: WebService/1.1.19415 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.206; envelope-from=luangruo@yahoo.com; helo=sonic311-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281633 Archived-At: Eli Zaretskii writes: > How did you test the build? What commands did you try? Basically what you said to do below, minus the custom button dropdown and C-z test. > . "M-x customize-variable", select some variable, and verify that > the drop-down menus in the Custom buffer work > . C-z, verify that you are dropped to a subordinate shell, invoke > some shell command, then type "exit RET" to verify that you are > back in Emacs Both work fine. > Thanks, see the comments below. >> --- a/msdos/sed1v2.inp >> +++ b/msdos/sed1v2.inp >> @@ -55,6 +55,10 @@ s/ *@LIBJPEG@// >> s/ *@LIBPNG@// >> s/ *@LIBGIF@// >> s/ *@LIBXPM@// >> +/^HAVE_NATIVE_COMP *=/s/@HAVE_NATIVE_COMP@// >> +/^HAVE_PDUMPER *=/s/@HAVE_PDUMPER@// > These two should be replaced with "no", not with empty values, I > think. Thanks. >> +/^JSON_CFLAGS *=/s/@JSOB_CFLAGS@// >> +/^JSON_LIBS *=/s/@JSOB_LIBS@// > Typos: should be JSON_CFLAGS and JSON_LIBS. >> +/^JSON_CFLAGS *=/s/@JSON_CFLAGS@// >> +/^JSON_LIBS *=/s/@JSON_LIBS@// >> +/^JSON_CFLAGS *=/s/@JSON_CFLAGS@// >> +/^JSON_LIBS *=/s/@JSON_LIBS@// > These should be redundant once you fix the typos above. Great catch, thanks. >> +OMIT_GNULIB_MODULE_crypto\/md5 = true > Don't we need md5? Why are you omitting it? It's only needed for the pdumper build, and that module doesn't build on MS-DOS. >> +ifneq ($(MSDOS_OBJ),) >> +temacs$(EXEEXT): $(LIBXMENU) $(ALLOBJS) $(LIBEGNU_ARCHIVE) $(EMACSRES) \ >> + $(charsets) $(charscript) ${emoji-zwj} $(MAKE_PDUMPER_FINGERPRINT) >> + $(AM_V_CCLD)$(CC) -o $@ \ >> + $(ALL_CFLAGS) $(TEMACS_LDFLAGS) $(LDFLAGS) \ >> + $(ALLOBJS) $(LIBEGNU_ARCHIVE) $(W32_RES_LINK) $(LIBES) >> + $(MKDIR_P) $(etc) >> +else >> ## We have to create $(etc) here because init_cmdargs tests its >> ## existence when setting Vinstallation_directory (FIXME?). >> ## This goes on to affect various things, and the emacs binary fails > Couldn't you use the original recipe by a trivial editing (it seems > all you need is to replace $@.tmp with $@?), instead of adding an > ifdef? Come to think of that, why not use the original recipe without > any changes, as it moves $@.tmp to $@ after the link succeeds? The linker apparently doesn't output a "stub" if the filename it's assembling to doesn't end with ".exe", resulting in an invalid binary. >> +int >> +fchmodat (int fd, const char *path, mode_t mode, int flags) >> +{ >> + if (fd != AT_FDCWD) >> + { >> + if (strlen (dir_pathname) + strlen (path) + 1 >= MAXPATHLEN) >> + { >> + errno = ENAMETOOLONG; >> + return -1; >> + } >> + } >> + >> + return 0; >> +} > This returns zero without doing anything, why? I think it should call > chmod when fd == AT_FDCWD. Thanks. >> +int >> +futimens (int fd, const struct timespec times[2]) >> +{ >> + /* TODO */ >> + return 0; >> +} >> + >> +int >> +utimensat (int dirfd, const char *pathname, >> + const struct timespec times[2], int flags) >> +{ >> + /* TODO */ >> + return 0; >> +} > > What about these TODOs? I forgot about those, good catch.