From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Findirect_function Date: Fri, 14 Jan 2022 14:00:34 +0100 Message-ID: <87o84e1ngt.fsf@elite.giraud> References: <87tue61tz1.fsf@elite.giraud> <69033893-9CEF-40D2-B10D-9702A37FDD2A@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10412"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: emacs-devel To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 14:13:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8MOp-0002RO-2L for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 14:13:47 +0100 Original-Received: from localhost ([::1]:54900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8MOn-0008Sx-J4 for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 08:13:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8MC8-0005qG-St for emacs-devel@gnu.org; Fri, 14 Jan 2022 08:00:41 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:7721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8MC6-00079h-Br for emacs-devel@gnu.org; Fri, 14 Jan 2022 08:00:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=DCy0KlwX5u1KiCJT eMJQF6BZzd7kl4Yf3xF+F19iyio=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=Phb9F8QDHX30o5KkbgEuvQDi7sRcKJi0OeeWta TA8x/8juSwxGqA4PxpB9ELSH+JJqPAIS1RVuA/MriN6bD4TTtPRloP1oYwXj1O5S20gxE1 vydxFoUoMJI5CKQZyhXe28jCXw3DV4bUTSRi6bk/Mc144Rs7B3gLf2q5OpLMpHFQzXK7aD OMciSWIeYzvRgUD6SIrXMwZZ6t8h6sBYanOP5f8XcHhS+wu8cLTXPnTzdXFXOm0Nhalls8 YUHt0wrLt57CIfvPp5u2yszOJuw5Eofd1ARUWwz6z2zyjxyxQ1eGuY+1AwcFx+71f7HkN4 iUQjMTawBlIHvsBOnfSQeVaQ== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id ddc63174 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 14 Jan 2022 14:00:35 +0100 (CET) In-Reply-To: <69033893-9CEF-40D2-B10D-9702A37FDD2A@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 14 Jan 2022 13:09:24 +0100") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284748 Archived-At: Mattias Engdeg=C3=A5rd writes: > 14 jan. 2022 kl. 11.40 skrev Manuel Giraud : > >> Maybe it is bike shedding territory (and maybe I'm missing something) > > Not at all, patches are always welcome! Thanks. [...] > Good! See if you can find more instances of this unfortunate > pattern. Even if it makes no difference for the generated code (very > likely), it obfuscates the source code. Ok, I'll look for this kind of pattern. > The other changes are less obvious since they may introduce extra > costs; some of these code paths are fairly hot. In addition, I'm > giving part of the interpreter an overhaul so perhaps we could drop > them for the time being. Do you agree? Yes it is one more C function call. Sure you could drop it! --=20 Manuel Giraud