From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Add 'pulsar' package Date: Sun, 20 Mar 2022 08:43:19 +0200 Message-ID: <87o821f7js.fsf@protesilaos.com> References: <87pmmpasom.fsf@protesilaos.com> <87ee359c2e.fsf@posteo.net> <871qz5x72t.fsf@protesilaos.com> <87v8wg1o7b.fsf@posteo.net> <87zglqdrht.fsf@protesilaos.com> <87h77x51d6.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.35 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 20 07:45:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVpJa-0002Bu-0K for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Mar 2022 07:45:22 +0100 Original-Received: from localhost ([::1]:60750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVpJY-0002D3-Kv for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Mar 2022 02:45:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVpHy-00015g-SP for emacs-devel@gnu.org; Sun, 20 Mar 2022 02:43:42 -0400 Original-Received: from [2001:4b98:dc4:8::226] (port=35945 helo=relay6-d.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVpHw-0007OC-Tu for emacs-devel@gnu.org; Sun, 20 Mar 2022 02:43:42 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id 29FBCC0006; Sun, 20 Mar 2022 06:43:19 +0000 (UTC) In-Reply-To: <87h77x51d6.fsf@posteo.net> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::226 (failed) Received-SPF: none client-ip=2001:4b98:dc4:8::226; envelope-from=info@protesilaos.com; helo=relay6-d.mail.gandi.net X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287314 Archived-At: On 2022-03-16, 16:05 +0000, Philip Kaludercic wrote: >>> I have no real opinion on this, I just wanted to bring it up in case you >>> hadn't considered it before (and also because in this case, at least from >>> what I understand the package does, it should be rather easy). >> >> I think a standalone package and a patch for 'master' are not mutually >> exclusive. As I wrote before, we can deprecate pulsar when Emacs 29 is >> the new stable and has this functionality built-in. >> >> As for whether such a patch would be easy, I admit that I do not know >> how best to implement it. If you or anyone else can write such a patch, >> please do it. > > I guess it might depend on how many features you want to re-implement in > the core. Please don't misinterpret this, but I think that the core > functionality, pulsing a line after certain commands, could be done by > providing a single user option, with a custom setter. As I wrote before, I do not know how best to do this in core. This is not me faking ignorance to support a different opinion: I genuinely do not know how to do this with a single option. Please do it if you can---it will also help me learn something new. At any rate, this is not what this thread is about. I think pulsar belongs in the archive. I post on emacs-devel to give others a chance to point out any obvious flaws with the package. If there are none, the patch must be installed in elpa.git (I have write access and can do that myself, if needed). There are people who are already using pulsar and I believe there is no technical reason why it should not be in GNU ELPA. To your point though about patching the core, I repeat what I already stated in unequivocal terms: I will deprecate pulsar when the Emacs version that includes its functionality becomes the stable version of Emacs. Until then, the package has a good reason to exist and be readily available. -- Protesilaos Stavrou https://protesilaos.com