From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James N. V. Cash Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Sat, 30 Apr 2022 08:41:24 -0400 Message-ID: <87o80i3frf.fsf@occasionallycogent.com> References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21595"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Juri Linkov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 30 14:42:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkmQX-0005T4-2h for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 14:42:21 +0200 Original-Received: from localhost ([::1]:48938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkmQV-0005Wd-Ld for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 08:42:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkmPh-0004k6-OY for emacs-devel@gnu.org; Sat, 30 Apr 2022 08:41:29 -0400 Original-Received: from mail-qv1-f48.google.com ([209.85.219.48]:40867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkmPg-0007IM-67 for emacs-devel@gnu.org; Sat, 30 Apr 2022 08:41:29 -0400 Original-Received: by mail-qv1-f48.google.com with SMTP id kc16so6206256qvb.7 for ; Sat, 30 Apr 2022 05:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=CKC8zJcTtBLfW0CUdpc4W5dVgFuekmE2Hw1+SJdUvF0=; b=RqBHVMPAhQRYnZ+pkuRiv1r5SOHdngXpaVORVhhSk84G9I7HNiSq4Fq23yBuT87EWh /QpgnI651COTea9SNC4MDbl7gbt38QkhEFa0FTcN4HNk8jpKJcLNklhe3AfRBGppgYzq ZipdVvPiW+eX82ffhqpU6EcuCdWy4qQSyffOlUbsRNV0ft+DzWxpp8z0RdTmzfyMdHxT /28MIuKl1Lcyeq+X2RJGSJVpU1qYyJ4tmWrGwzVw0gdshNpNHhb/huIQkmSJNHauRurH 0HvQmtsF1dFT4k7d+LvoM04vfro5t9RThFciqnatLFTjETJ2Q2lKqQPzDCskdvbIEB2W pgPg== X-Gm-Message-State: AOAM532vP8hO/LFnrewdSQ50Fh7ojQMlAilhFGrHi1jILhcuQdomJlIV ZzsAQ2nPr7/0fIRCHxqWxGho/XCTHM0= X-Google-Smtp-Source: ABdhPJwLp3Ny4argcG+7I0mwN71AqkOM/iyvezQBUZw9jXJdYicQrtIXz5zJBM47N2pX/mSSsr/Tnw== X-Received: by 2002:a05:6214:3007:b0:456:520f:70ab with SMTP id ke7-20020a056214300700b00456520f70abmr2775869qvb.124.1651322486707; Sat, 30 Apr 2022 05:41:26 -0700 (PDT) Original-Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id d25-20020a05620a167900b0069fc13ce1d6sm1116778qko.7.2022.04.30.05.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Apr 2022 05:41:26 -0700 (PDT) Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id E2D0E27C0064; Sat, 30 Apr 2022 08:41:25 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 30 Apr 2022 08:41:25 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddugdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomheplfgrmhgvshcu pfdrucggrdcuvegrshhhuceojhgrmhgvshdrnhhvtgesghhmrghilhdrtghomheqnecugg ftrfgrthhtvghrnhepudehtdeukeekiedvfeekudefkeeileejgeehfffhieevuefhkeeu ffefgfeileeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepjhgrmhgvshgptggrshhhodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithih qdduvdefvddtvdejledvqddvjeekgedtudehvddqjhgrmhgvshdrnhhvtgeppehgmhgrih hlrdgtohhmsehotggtrghsihhonhgrlhhlhigtohhgvghnthdrtghomh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 30 Apr 2022 08:41:25 -0400 (EDT) In-Reply-To: Received-SPF: pass client-ip=209.85.219.48; envelope-from=james.nvc@gmail.com; helo=mail-qv1-f48.google.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289052 Archived-At: Stefan Monnier writes: >>> + (let ((beg (if (number-or-marker-p beg) >>> + beg >>> + (save-excursion >>> + (goto-char (minibuffer-prompt-end)) >>> + (search-forward beg)))) >>> + (end (if (number-or-marker-p end) >>> + end >>> + (save-excursion >>> + (goto-char (point-max)) >>> + (search-backward end))))) >> >> What if there are several matches for `beg` and/or for `end` in >> the buffer? How do we know we got the intended one? > > IIUC part of the purpose of using strings rather than positions is to > account for the case where the text was modified between the moment the > *Completions* list was created and the moment the user selects one of > the options. So another question is what to do if the search fails (the > above code signals an error in that case, which is probably not what we > want). That is a good question. That would happen, I guess, if you had selected multiple candidates in a CRM, started completing, then deleted the previously entered candidates, then selected one. I suppose I'd expect it to add the completed candidate to the end of the remaining list? So something like (let ((beg (if (number-or-marker-p beg) beg (save-excursion (goto-char (minibuffer-prompt-end)) (or (search-forward beg nil t) (search-forward-regexp crm-separator nil t) (minibuffer-prompt-end))))) James