From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: emacs-devel@gnu.org
Cc: Gregory Heytings <gregory@heytings.org>
Subject: Re: feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling.
Date: Sat, 23 Jul 2022 14:40:53 +0300 [thread overview]
Message-ID: <87o7xgcb0a.fsf@tcd.ie> (raw)
In-Reply-To: <20220716191457.3B0FAC00095@vcs2.savannah.gnu.org> (Gregory Heytings's message of "Sat, 16 Jul 2022 15:14:56 -0400 (EDT)")
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
Gregory Heytings [2022-07-16 15:14 -0400] wrote:
> branch: feature/fix-the-long-lines-display-bug
> commit e7b5912b235936b304701ba6b1e808d9b197fd4f
> Author: Gregory Heytings <gregory@heytings.org>
> Commit: Gregory Heytings <gregory@heytings.org>
>
> Improvements to long lines handling.
>
> * src/buffer.h (struct buffer): New field 'long_line_optimizations_p'.
[...]
This seems to have given rise to the following build error with
--enable-checking=structs:
pdumper.c: In function ‘dump_buffer’:
pdumper.c:2705:3: error: #error "buffer changed. See CHECK_STRUCTS comment in config.h."
2705 | # error "buffer changed. See CHECK_STRUCTS comment in config.h."
| ^~~~~
Is this the right fix?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Update-pdumper.c-after-recent-long-lines-changes.patch --]
[-- Type: text/x-diff, Size: 1516 bytes --]
From ea925aac28cf96fe1ad5736850386e24cc259a7c Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Sat, 23 Jul 2022 14:22:09 +0300
Subject: [PATCH] Update pdumper.c after recent long lines changes
* src/pdumper.c (dump_buffer): Dump new field
long_line_optimizations_p introduced in commit e7b5912b23 of
2022-07-16 "Improvements to long lines handling."
(dump_buffer) [CHECK_STRUCTS]: Update hash accordingly
for --enable-checking=structs.
---
src/pdumper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/pdumper.c b/src/pdumper.c
index af451920eb..33cb804dba 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -2701,7 +2701,7 @@ dump_hash_table (struct dump_context *ctx,
static dump_off
dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer)
{
-#if CHECK_STRUCTS && !defined HASH_buffer_F8FE65D42F
+#if CHECK_STRUCTS && !defined HASH_buffer_AA373AEE10
# error "buffer changed. See CHECK_STRUCTS comment in config.h."
#endif
struct buffer munged_buffer = *in_buffer;
@@ -2813,6 +2813,7 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer)
DUMP_FIELD_COPY (out, buffer, prevent_redisplay_optimizations_p);
DUMP_FIELD_COPY (out, buffer, clip_changed);
DUMP_FIELD_COPY (out, buffer, inhibit_buffer_hooks);
+ DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p);
dump_field_lv_rawptr (ctx, out, buffer, &buffer->overlays_before,
Lisp_Vectorlike, WEIGHT_NORMAL);
--
2.35.1
[-- Attachment #3: Type: text/plain, Size: 20 bytes --]
Thanks,
--
Basil
next parent reply other threads:[~2022-07-23 11:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165799889678.19490.7919197387382513250@vcs2.savannah.gnu.org>
[not found] ` <20220716191457.3B0FAC00095@vcs2.savannah.gnu.org>
2022-07-23 11:40 ` Basil L. Contovounesios [this message]
2022-07-23 13:20 ` feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling Eli Zaretskii
2022-07-23 13:51 ` Basil L. Contovounesios
2022-07-24 11:14 ` Robert Pluim
2022-07-24 11:45 ` Eli Zaretskii
2022-07-24 12:10 ` Robert Pluim
2022-07-25 20:50 ` Gregory Heytings
2022-07-26 11:07 ` Eli Zaretskii
2022-07-26 11:28 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7xgcb0a.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).