From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: ELPA submission: python-import Date: Sat, 30 Jul 2022 13:58:34 +0200 Message-ID: <87o7x6ke1h.fsf@fau.de> References: <87v8rguhry.fsf@gmail.com> <871qu3synn.fsf@posteo.net> <871qu3klyi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8550"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Stefan Monnier To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 30 15:10:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHmEd-00021t-KL for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 15:10:27 +0200 Original-Received: from localhost ([::1]:40272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHmEb-0001r0-Vb for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 09:10:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHl7K-0003HZ-HF for emacs-devel@gnu.org; Sat, 30 Jul 2022 07:58:50 -0400 Original-Received: from mx-rz-3.rrze.uni-erlangen.de ([2001:638:a000:1025::16]:58035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHl7H-00060M-8I for emacs-devel@gnu.org; Sat, 30 Jul 2022 07:58:50 -0400 Original-Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-3.rrze.uni-erlangen.de (Postfix) with ESMTPS id 4Lw2wL66s6z20TW; Sat, 30 Jul 2022 13:58:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fau.de; s=fau-2021; t=1659182322; bh=ckagjQTWlMkq5ASp9OJnmhPgyXVFYYQwjprCB6sDsTc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:To:CC: Subject; b=BftMXbUM0pF5eUTke4D8DxAjGH1aXTuXMygarCL5F0rsfDftzXPt6gOrFReyLSVIj l30lbLz0MR3XGWEwM1KylHFqxCQpTDlygOn0k+XIUce5iUSRDEfIFXxptmDIZJexV4 OxW1D/Vo0TxnuFtjNtTroqjyN5FZ+jT64u8KasE0zKkYVE2x4n1nY6LhM6JNZ22g8r EvNz9URloOdOJNRZfflEluIYZiPYLhaBx3M8Wh+S21LVBgvPggt7nEoFTUyLPM4F3v FXvucnit1DpQvDd3U9Ge9zhP8wkxlzhyap6KPIqlgftoF4vxd5bmu4dzU1XFu6Lrog gbwwCef1ItJ8g== X-Virus-Scanned: amavisd-new at boeck1.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 2003:f8:71e:d884:ea1c:b1b9:c8ee:d52b Original-Received: from rhea (p200300f8071ed884ea1cb1b9c8eed52b.dip0.t-ipconnect.de [IPv6:2003:f8:71e:d884:ea1c:b1b9:c8ee:d52b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX18aT5tA0iaK5+WLocEHatUKXzCpttcDJdA=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 4Lw2wJ2fjgz1ykN; Sat, 30 Jul 2022 13:58:40 +0200 (CEST) In-Reply-To: <871qu3klyi.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 30 Jul 2022 11:07:33 +0200") Received-SPF: pass client-ip=2001:638:a000:1025::16; envelope-from=philip.kaludercic@fau.de; helo=mx-rz-3.rrze.uni-erlangen.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 30 Jul 2022 09:07:57 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292874 Archived-At: Augusto Stoffel writes: > Hi Philip, > > See my response to your comments below. > > But more importantly, since now the plan is to add those features to > python.el, which is built-in but also extracted to be distributed on > ELPA for Emacs =E2=89=A5 24.4 --- have you thought of a scheme whereby on= e could > use new Emacs features on those kinds of packages, but then > automatically stick a (require 'compat) at the top of their ELPA > version? We have recently added compat as a dependency for ERC, but that only required support back until 27.1. Sadly it isn't as simple as just adding (require 'compat nil 'noerror) at the top of the file, as compat is neither complete not transparent. I am not saying it isn't impossible, but if there is a dependency on project.el, it might make sense to raise the minimum version of ELPA's python.el? Alternatively, one could try and reduce the minimum version of project.el, but that might be tricky. > On Fri, 29 Jul 2022 at 17:53, Philip Kaludercic wrote: > >> Why do you depend on Emacs 28.1? Setting aside convenience functions >> like length=3D, all you really need is project-files from Emacs 27.1, >> right? And if you add a dependency on the right version of project.el >> that implemented that function, you could even reduce the (transitive) >> dependency to Emacs 26.1. > > I'm also using the MODES argument of the `interactive' form. But yes, I > have no good reason to require 28 other than being unfamiliar/not > remembering the history of the new features, which makes it hard to > "promise" compatibility with older Emacsen. Good point, I had missed that. I still believe that was an unfortunate design decision, but as Visuwesh using the declare form might help? >> I am not familiar with isort, and I suppose there are other lightweight >> Emacs users like me who haven't heard of it either. It might therefore >> be good to add a link to some documentation, especially on how to >> install it since that can sometimes be tricky when using Python. > > Sure, I'll will do that.