From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 152c7322c1: * lisp/net/tramp-docker.el: New file. Date: Mon, 03 Oct 2022 19:37:33 +0200 Message-ID: <87o7usolk2.fsf@gmx.de> References: <875yh6untf.fsf@miha-pc> <87zgeihyzb.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23352"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: miha@kamnitnik.top, Brian Cully , emacs-devel@gnu.org To: Brian Cully Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 03 19:45:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofPVj-0005sN-E9 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Oct 2022 19:45:47 +0200 Original-Received: from localhost ([::1]:32782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofPVi-0002pT-5w for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Oct 2022 13:45:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofPO4-0008HP-65 for emacs-devel@gnu.org; Mon, 03 Oct 2022 13:37:52 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:46199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofPNy-0003Qj-AB for emacs-devel@gnu.org; Mon, 03 Oct 2022 13:37:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664818655; bh=TmVzqx2lZe6Zc0HCn/OW1KD6OsG++IHOjDfmPQOaCBk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=BLlGG9yPFq888Grwq59TIwBpXalRamaeipN+uzDcDn/Nq8p+mnssy+wCTdeuRCGJO 9AQEDgouZku/R6yTWp4QSe4LSg1D6NTcYn1KWsJnSHtnkGNiJqMEuaaaYUia1l2TBa wdEt+W/kV7T4aM464zdtPD06Yuj/3QH730XwRy3U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.156.128]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MPXhK-1os6wP2x62-00MgK0; Mon, 03 Oct 2022 19:37:35 +0200 In-Reply-To: (Brian Cully's message of "Mon, 3 Oct 2022 09:44:16 -0400") X-Provags-ID: V03:K1:uGhwxaPdPFs/CgNPQR7Lt8rI3r8vCAcayw3cd4PDxabQgRJjqiQ gCSCfEAhV8Pl/Jat0U3XML4UOC2r53xl3m8czXavDi4blXlw5uLz19xdz6SkzWwti2IvH3u uYVkvD4sunuFti2IUWb2nscF0K9S+YwnoLt+A+C1KLHljGSecqY2x5hnGGbzlOJzR7vntVw DztmG98L4t9ZdhlTaY+WA== X-UI-Out-Filterresults: notjunk:1;V03:K0:fV666BY9ASk=:/+An5EDhZfKxbP2CDesfcr /SJOmybqAifvLqrrXwcf2UP8J/E0IQK/JYw6Nj0gaAPKrUvWqNTPJF0jFR5WJNlkNvzWS/FfK 9zjL5iwzux8PqGLco+9sZsRH8XkfVb9eihkbhbafS8dDm5u0ZOLZZxHx3bz/zmDxzgxEY2VXT aspYGAtFi6nKrhPJmXLNphxupxVOq8RkIGePtQbtFuD+ExRfQYtdJGXGN0UmAoFziW3OiJSVY FDXetxmtgjmpmE7WnUNc1/jq/JXJFyGSj4MP1+HnwZaDIRMi1Fk7xGV6Qcx/WEAP+0z2sOxvm lM08Q4Bx0TUyefGalYr74c0GZVXnjNh8joD8CdTdqhFkbrGUIRlwQkedZ0RZCPm1deOrMov4x f0hZ+1RY6Ms7eNiXoyXEhiAeTwcDDJ9vp2S91lABMKy6z1RbfZV59eWhwroxd1/7zsUOctxS3 1QwQSj9udmb3RIXpvYVhvLLA5HzFFuG4AG4Mn2Z++Q2T+hcQyHySoPj1tCAcLWdYOHQEgt/e7 FKtUCMlN9gD9YJi3rVUj/KWAI4Lroeo1xlOxGbtpRvlZTxYOjP4kIhIDiySiL6M1+J3dc1NtT 3aTurCcBbNgso7FQ3baq+ZwN5j2cTW4Y4gfANcGUDuIr3Pfe+iSsKqBjE5Qtm0fZFQ5y5j0sN s4yeWQyk9Lb23RudXUgZoU/mz//oUw1xMH265W+RxJN/9E8/HVwpC8R2+1llBEOr7/jl0d5xn kyIG9Om799p6apf35qYEMqmKoAmdYOcwahrjh3RkoUXfXaKTnc8h0zniDU0nyJcs7aZglvOC Received-SPF: pass client-ip=212.227.17.20; envelope-from=Michael.Albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296773 Archived-At: Brian Cully writes: Hi Brian, > Indeed. I hadn't considered this use-case (even though I also have > both installed, though I only use Tramp with Podman containers for > development purposes). > > As the package is really not much more than the method and variable > customization options, it may be best to just have duplicates for > those (eg, both `tramp-docker-program' and > `tramp-podman-program'). The completion code could be shared, but I'm > unsure how higher-level code organization would work. My first pass > would be to have a single `tramp-docker--completion-function' which is > used for both the `tramp-podman-method' as well as > `tramp-docker-method'. My rationale being that Podman explicitly > copies the Docker command line so that at can be used as a drop-in > replacement, so the completion function would more naturally be > associated with Docker than Podman. OK. Would you like to provide a patch? Including a ChangeLog-like commit message. > -bjc Best regards, Michael.