From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Eglot: auto-import completion item Date: Mon, 21 Nov 2022 13:56:16 +0000 Message-ID: <87o7t09zsv.fsf@gmail.com> References: <83a64pewpw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Marcin Pajkowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 21 14:55:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ox7H0-0002oi-6t for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Nov 2022 14:55:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox7GO-0007rX-MU; Mon, 21 Nov 2022 08:55:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox7GK-0007qg-CM for emacs-devel@gnu.org; Mon, 21 Nov 2022 08:55:05 -0500 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox7GI-0003RI-UJ; Mon, 21 Nov 2022 08:55:04 -0500 Original-Received: by mail-wm1-x32f.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so9055100wmi.3; Mon, 21 Nov 2022 05:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XNwlpWqRe3bjkHSL/8+/kOQwpxC0zT0URzjh4sg4tQ0=; b=QR1WCfWb68w7veyyP8wwZpJqFhSytfk8gRkwUtYL0rf9NxlvecH4MfeJHKV/OKyGWa qaLkrba2iTabYkSv3u6/SgEhlRR7/O99oXmGBnA31IY9utoDM6p22/vsz7J8bSqctyhD e9N4rre/RvsjJjtTfzlhY6ncsgwEyv1h5DV1sMuZ6UeY4JlTzy0ZtX+vbL2BNX4uCZmi FVSSKNli4PyrdDFE/a0HZ/1lngnVvlaaGIfyo14OnZcBhRgv/YV6gqfDSEqB6MbTMXCp QKvfGvhzK3VyOCssUsDDkwdP4ixXuo3+r71ekaWR+BT8Gj66TjLWKkrzDuQIbibGDNhy I1pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XNwlpWqRe3bjkHSL/8+/kOQwpxC0zT0URzjh4sg4tQ0=; b=vpIjXLZVweXKxB6BDaoHGAHxToyiaJxD8Akl5MFeFAaQhhf38gSscucWfvrjp/MktM 6ZdWEHiJPo3EU5yDBJGgyc/9l03Od0+iVU9qrXOoqJawyNnVBntAxE92mNLJDPuyrgG1 yNNKHLxWDdnTbtW2UqjDOQHL6CpjX7RsBd027qCW5d4Jr4Ta657gNKJyXJVtxtQ/edQ/ 1+OFVmNUJW8Oyu1BHOIyRmngVAtiPT/loOQ3TH9UTaxznmQx8qnVsESw6groPqpjA03X fOJe1ZzZqpsX0CjW9cDsJb8+rNWbSsShlsvMA+V7ObijeX2rmnHFbHePFSKT1cVGlZqw fwSA== X-Gm-Message-State: ANoB5pkH7bEGTF91HG9tddeAWtLaRaO59x7zkW8FuQO2XCldsv93JHbO UyNhSFrb/MXcLpbeld9x7+dXl3/44wY= X-Google-Smtp-Source: AA0mqf6Hh3fz/XBkD5PHw3AzumCLwaR1Mt7fAfJn+uNTF5U2gjtp0FDtaLuyqAZaU706D3SmQfzOnA== X-Received: by 2002:a05:600c:21c6:b0:3c7:19a6:8146 with SMTP id x6-20020a05600c21c600b003c719a68146mr13159890wmj.158.1669038900463; Mon, 21 Nov 2022 05:55:00 -0800 (PST) Original-Received: from krug (87-196-81-26.net.novis.pt. [87.196.81.26]) by smtp.gmail.com with ESMTPSA id y8-20020adfee08000000b0024194bba380sm11245944wrn.22.2022.11.21.05.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 05:54:59 -0800 (PST) In-Reply-To: (Marcin Pajkowski's message of "Sun, 20 Nov 2022 21:52:43 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300297 Archived-At: Marcin Pajkowski writes: Hi Marcin, the patch looks good to install, but please send it to the bug tracker where the discussion started instead: I don't have the bug # handy. Minor comments below my sig. Jo=C3=A3o > Subject: [PATCH] Eglot: Advertise completion.resolveSupport capabilities > > Some servers avoid reporting completion items that require > "additionalTextEdits" capability. Actually eglot-completion-at-point > function supports such feature so it can be adverised to LSP server. ^^^^^^^^^ typo! Also missing a line bug#xxxxx here. > * lisp/progmodes/eglot.el (eglot-client-capabilities) Here's, you're supposed to add a ':' and then briefly state what you did to the definition. Like this: * lisp/progmodes/eglot.el (eglot-client-capabilities): Advertise :resolveSupport. > --- > lisp/progmodes/eglot.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 9555d21b00..4193ee0106 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -737,6 +737,7 @@ eglot-client-capabilities > t > :json-false) > :deprecatedSupport t > + :resolveSupport (:properties ["doc= umentation" "details" "additionalTextEdits"]) Can you break this line so that it fits in under 80 columns? > :tagSupport (:valueSet [1])) > :contextSupport t) > :hover (list :dynamicRegistration :json-false