From: "João Távora" <joaotavora@gmail.com>
To: Marcin Pajkowski <marcin.pajkowski@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Eglot: auto-import completion item
Date: Mon, 21 Nov 2022 13:56:16 +0000 [thread overview]
Message-ID: <87o7t09zsv.fsf@gmail.com> (raw)
In-Reply-To: <CAPZ_WREDX_QyfJu_WNAjUYd_w-UAMcD0YuWjk=k=+pzQTRaShw@mail.gmail.com> (Marcin Pajkowski's message of "Sun, 20 Nov 2022 21:52:43 +0100")
Marcin Pajkowski <marcin.pajkowski@gmail.com> writes:
Hi Marcin,
the patch looks good to install, but please send it to the bug tracker
where the discussion started instead: I don't have the bug # handy.
Minor comments below my sig.
João
> Subject: [PATCH] Eglot: Advertise completion.resolveSupport capabilities
>
> Some servers avoid reporting completion items that require
> "additionalTextEdits" capability. Actually eglot-completion-at-point
> function supports such feature so it can be adverised to LSP server.
^^^^^^^^^
typo!
Also missing a line bug#xxxxx here.
> * lisp/progmodes/eglot.el (eglot-client-capabilities)
Here's, you're supposed to add a ':' and then briefly state what you did
to the definition.
Like this:
* lisp/progmodes/eglot.el
(eglot-client-capabilities): Advertise :resolveSupport.
> ---
> lisp/progmodes/eglot.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 9555d21b00..4193ee0106 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -737,6 +737,7 @@ eglot-client-capabilities
> t
> :json-false)
> :deprecatedSupport t
> + :resolveSupport (:properties ["documentation" "details" "additionalTextEdits"])
Can you break this line so that it fits in under 80 columns?
> :tagSupport (:valueSet [1]))
> :contextSupport t)
> :hover (list :dynamicRegistration :json-false
next prev parent reply other threads:[~2022-11-21 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 13:23 [PATCH] Eglot: auto-import completion item Marcin Pajkowski
2022-11-17 9:50 ` Eli Zaretskii
2022-11-17 10:41 ` João Távora
2022-11-20 20:52 ` Marcin Pajkowski
2022-11-21 13:56 ` João Távora [this message]
2022-11-22 20:26 ` Marcin Pajkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7t09zsv.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=marcin.pajkowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).