From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: How to install documentation in sub-directory with Package VC? Date: Wed, 15 Mar 2023 09:41:50 +0000 Message-ID: <87o7oujqqp.fsf@posteo.net> References: <87bkkvconh.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35110"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Okamsn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 15 10:42:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcNe0-0008wD-Vm for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Mar 2023 10:42:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcNdU-00014T-Qj; Wed, 15 Mar 2023 05:41:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcNdT-00014I-Oc for emacs-devel@gnu.org; Wed, 15 Mar 2023 05:41:31 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcNdR-0005qg-23 for emacs-devel@gnu.org; Wed, 15 Mar 2023 05:41:31 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3B03C240688 for ; Wed, 15 Mar 2023 10:41:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1678873287; bh=s91RLQj/aWDX3kcLFTqU0ob8wGfwXmVHIEQpjiwdO60=; h=From:To:Cc:Subject:Date:From; b=DnwWVlXoCdvNiLwl6bH+wH/SvuS6Usxj8C8vlmx/SGRfgz6V8eZyQ+TleMLOucxns 2GMoGGEQNpRv4ZoJzxzMbAOVrjcSiXlWnhqorrLFCTWgzqc3IiaD75wXLANQJiXwtY DJGBBO9duvrptW3gPnZ1sUDBuwSjrqJCNZJMkOGw/ZaYa1/IWfmCkNMmH7V2I0wJAI jQ6TrP0s00fNI5dBox+5r5KtuqrqM1MCR+2Fmy83QUro8BNWJGZ2UvVtHw4VxUXn7k o+bFX5E88ft8WpovEQlUCQnH/vrXzkECh2Z7bQWZthSDK+yYaCsfrFIMZuZ7frvvU+ UYhUDIJADLKJQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pc54k5RfLz6tmQ; Wed, 15 Mar 2023 10:41:26 +0100 (CET) In-Reply-To: <87bkkvconh.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 14 Mar 2023 15:56:34 +0000") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304485 Archived-At: Philip Kaludercic writes: >> What is the correct way to make Package VC install the documentation >> contained in the sub-folder? > > Package-vc uses ELPA package specifications, which you can also pass to > `package-vc-install': > > (package-vc-install '(loopy :url "https://github.com/okamsn/loopy" > :doc "doc/loopy.texi")) > > That being said I have found a bug in `package-vc--unpack-1' and > `package-vc--desc->spec' in that it fails to re-locate the > specification. This is a general problem, whenever packages are > installed with a provided specification. One trick might be to also > consult `package-vc-selected-packages', but that wouldn't solve the > issue we have here. > > I believe a general fix would involve storing new or custom package > specifications in a user option, which probably cannot be > 'package-vc-selected-packages', similarly to > `package-selected-packages'. I have made the change alluded to here, in the commit 168165178f32fb4e20aea32858407921baf079f0, which has been pushed to the emacs-29 branch. This has also allowed for some other simplifications to be made, which is nice. The above `package-vc-install' now works on my end, and I see the Loopy manual listed under (dir)Top.