From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: tramp "too many open files" [Re: bug#56606 Date: Tue, 21 Mar 2023 13:43:36 +0000 Message-ID: <87o7omgqut.fsf@posteo.net> References: <86ilnwafso.fsf@stephe-leake.org> <86a6989itv.fsf@stephe-leake.org> <8335f0qbvn.fsf@gnu.org> <831qujrjnm.fsf@gnu.org> <86h73ex91m.fsf@stephe-leake.org> <83k089omhb.fsf@gnu.org> <87v8ivii64.fsf@posteo.net> <87jzzbzbys.fsf@gmx.de> <87r0tjibia.fsf@posteo.net> <871qljz4q4.fsf@gmx.de> <87ileuiqph.fsf@posteo.net> <87fs9ysblu.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Madhu , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 14:46:50 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pecK8-0007XM-U1 for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 14:46:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pecJM-0006Tk-Cx; Tue, 21 Mar 2023 09:46:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pecJK-0006TJ-IR for emacs-devel@gnu.org; Tue, 21 Mar 2023 09:45:58 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pecJH-0000eQ-SL for emacs-devel@gnu.org; Tue, 21 Mar 2023 09:45:57 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4472D240461 for ; Tue, 21 Mar 2023 14:45:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679406353; bh=/QuhxE7LLRZwiSxCaIdQhSwOtInFBykdN7CZecTnm3E=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=JthbwMd+zk3WJelKBW8J4SnhN9afbCnrB0G1yXtcN82Fn3U8PgOa4xOvKuvN+uO6L 6sJ7DiZRwyZAVulbEqMeIu8zjdustJrqFInndULsCbeGBteqUNZsmD6KGSn+3fxCcA MvByxZNMyo+vzdRx9YlOin+/adtTi/VaVcfcjvUBY40RfgIavUj8+ynzwE2sQHj0CJ v2shVvhFmvnnsKaIrHGcdni6Ta2CYkfN3QoFmR/n8DTubnA0CgRXR0cAw+nzlP37Gz vM7gqarpnpJiouXBfwIogEYTXFu7kSyk0azDmPMxZk3ciOartyvXXIR3lKRMxbrVL5 dFQqMQgAeKW/Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PgtCz1gghz9rxK; Tue, 21 Mar 2023 14:45:50 +0100 (CET) In-reply-to: <87fs9ysblu.fsf@gmx.de> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MAedi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0pkcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfbtG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQGVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqCWcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEAAc0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8hBp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslxhU46VSz1Z83NwIG3mpdYNV5WUTUdgzx ExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304651 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Michael, Michael Albinus writes: > Thierry Volpiatto writes: > >> Hello Michael, > > Hi Thierry, > >>> And also, tramp-archive-file-name-handler checks in case of a file name >>> "/path/to/file.tar/", whether "/path/to/file.tar" is a directory. >>> In this case, tramp-archive also ceases to work. >> >> Yes, the problem we had in Helm was with while-no-input, when a check in >> done under it (file-directory-p or whatever) a dbus event is sent and >> while-no-input fails, we have to let bind while-no-input-ignore-events >> with the new dbus-event added to fix the problem, perhaps tramp-archive >> should take care of this? > > Indeed. dbus-event, file-notify and thread-event have been added to > while-no-input-ignore-events in Emacs 29. What about the following > patch? Yes looks good, I use about the same code in Helm actually. Thanks. > diff --git a/lisp/tramp-gvfs.el b/lisp/tramp-gvfs.el > index 7323374c..0d23f5d8 100644 > --- a/lisp/tramp-gvfs.el > +++ b/lisp/tramp-gvfs.el > @@ -872,6 +872,14 @@ arguments to pass to the OPERATION." > (tramp-register-foreign-file-name-handler > #'tramp-gvfs-file-name-p #'tramp-gvfs-file-name-handler))) > > +;; Event type `dbus-event' is added to `while-no-input-ignore-events' > +;; in Emacs 29.1. If it is missing, some packages like Helm report > +;; problems. So we add it here. > +(when (and (featurep 'dbusbind) > + (not (memq 'dbus-event while-no-input-ignore-events))) > + (setq while-no-input-ignore-events > + (cons 'dbus-event while-no-input-ignore-events))) > + > > ;; D-Bus helper function. > > >> Thanks. > > Best regards, Michael. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmQZtQoTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkztRC/9dcA7j/jYiLnunc8wRq1pIwkgjRbWn FknvCSqfDhcVshVZmFRp9IVjqeIDxupPc74n2suhS9TAwdDyAneypSKn1xNyB+Lq +4aHKFG1/3+RRk9rc20W9eybm5njA77ypfkvATRf1sGTv3KVAg+O9p1abJkRAgBE Q10FLHuOonkEWdWsG4dEaGKHn/fO/y7jjZRN/rLhiaerSQJe3GgaoyXLUsMMGg+P o+AqSsr8ibdusDNBh01tWspaJ/f5Y+Q0yQHtNykxiUE7vrFHQ8I8X3Kzj1PFdhRz t91cqhLq81MK/ud4TTQ86d1NVZTtTifZhh23ahUZweSDKvvj08UkYPqzpQ3OWABJ vvpT9lOXqqROmzMBPoKyrso5V2Au6mfvHx4vDYaASPOQrPUW1WB9KjGM19kLZood UUoKQRTrUTQjfXTK0pxNdKmi2EHsWuLlsKZWuYTIoJNozW/qiJJlDmP0eYwQRaZQ qp1TgaSgMN7qnSWjMPReTEYUxQZfzIZfDWw= =KNsj -----END PGP SIGNATURE----- --=-=-=--