From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Wed, 31 May 2023 14:38:33 +0000 Message-ID: <87o7m0k1li.fsf@localhost> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> <83edmwfz6p.fsf@gnu.org> <87r0qwk6bz.fsf@localhost> <83ttvseg3k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 31 16:35:11 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4Mus-0000Bw-B1 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 May 2023 16:35:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4Mu6-0002tU-39; Wed, 31 May 2023 10:34:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Mu2-0002tE-CT for emacs-devel@gnu.org; Wed, 31 May 2023 10:34:18 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Mtx-00054w-Cb for emacs-devel@gnu.org; Wed, 31 May 2023 10:34:18 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EAFB424002B for ; Wed, 31 May 2023 16:34:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685543651; bh=o6WgiEaw4VDjqJ7ohJatUdCjZ8Q4Wj/LU4aO3Ar2Quk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=hne590jbf++vkdw+xO8zKYDJcF3P6EOhUdI4eWz54M4pkAvTlMuDiIo9EMYljIFnC 4e/uEMeEqSUfQKDLSRMeXccD3+/0idO9AQVBEqRWEuGpp+TDUc4O/OILY8qrqVBPY7 MsMnF/hDPotueYDj2BLdAWE2eSwBEnuiweruUhacbeyhGFd12Dd0jI0YkMPfpnJQg6 uIz/hw9bJ0phvQ68QE14MLJZLLW3u6nvAN7y12oU/mTWzIqYe61eOQae9E3hBMLHZc qGUE3dEaPk/3z6NMUYdXBH1AollPIlzgkzqa4RFc6mwTzraSomeN2qx6JJv/q9h3sP phj+YIbWMDFKQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QWWwy2hHNz9rxK; Wed, 31 May 2023 16:34:10 +0200 (CEST) In-Reply-To: <83ttvseg3k.fsf@gnu.org> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306450 Archived-At: Eli Zaretskii writes: >> I expected `isearch-filter-predicate' to be only used by isearch in >> isearch-mode. And thus I expected `isearch-mode-end-hook' to be called >> later. >> >> Isn't it a natural expectation? > > Evidently, that ship sailed a long time ago: "grep isearch-" yields > more than 60 hits in replace.el. And then there are many hits in > comint.el, dired-aux.el, info.el, and even in simple.el. Sure. I have no issue with this. That's why I asked to add a word of warning about the state of affairs to the docstring. It is not normal that major mode-specific predicates are used elsewhere. >> > (I also don't understand what does isearch-range-invisible have to do >> > with this.) >> >> `isearch-range-invisible' can modify `isearch-opened-overlays' and >> `isearch-hidden' by side effect. > > Yes, but why it is relevant to your problem? This was one of the reasons I thought that side effects are ok. Also, the fact that `isearch-hidden' can be modified outside isearch might yield edge cases when something like M-x query-replace calls `isearch-range-invisible' that happens to set `isearch-hidden' to t. Later, if there is a followup M-x isearch call, `isearch-hidden' will remain t. Modifying `isearch-opened-overlays' should not cause such interaction, AFAIU. It is initialized to nil at the beginning of isearch. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at