From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Sat, 03 Jun 2023 01:06:58 +0200 Message-ID: <87o7lxpip9.fsf@web.de> References: <875y8nks9t.fsf@localhost> <87fs7c10cq.fsf@web.de> <87v8g79zoe.fsf@localhost> <87sfbasr8m.fsf@web.de> <87y1l244hz.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21320"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 03 01:07:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5DsC-0005Kn-3x for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Jun 2023 01:07:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5DrR-0006jj-7W; Fri, 02 Jun 2023 19:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5DrP-0006jY-EG for emacs-devel@gnu.org; Fri, 02 Jun 2023 19:07:07 -0400 Original-Received: from mout.web.de ([212.227.15.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5DrK-0003mG-DG for emacs-devel@gnu.org; Fri, 02 Jun 2023 19:07:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1685747219; x=1686352019; i=michael_heerdegen@web.de; bh=g9VZ3g+MhIm1iI7kO26ZKEujdx8NA0vZVO7pDG8i5us=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=VIZpvMVOqhTa6UxAR7pktYbxL+fccLF6g22gkVV8YMCO9i9T0m3Y4IEkcOmbHyLLaCVE7+5 /B3T0PoJTezKIYjLHUcFTB2Xh2lrx7GOwvc2jlMhvrCBf1qnx3th0ObK2+QxXoNvwux96y+52 /CN5Edw3mN92l15BKfSX2yveYqjxF8M7svRLMFHbFZrXqAsid8fUa0QlguQrmd+TNfGeRJc6X XgUAp+04DGNXcBe0CSpsvY8GELxqZvAPIhLlaUoPGxPoM5G7mnyq4tZW5jv48wX0+eHn0ofTP GecdBqJrcXVwGnLcD9mXCThOAxoHv9qTPUh38p77Qhv/X1SkUYXw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1McIki-1qdSkZ1UwG-00clEo; Sat, 03 Jun 2023 01:06:59 +0200 In-Reply-To: <87y1l244hz.fsf@localhost> (Ihor Radchenko's message of "Fri, 02 Jun 2023 09:07:04 +0000") X-Provags-ID: V03:K1:zBp8fAdI+UWxR63pQZKfvQ3OoCCufg1iaWCPMgxn8MJnHaflSUg 8n4CXLZ0Io6bmswSvBaWlQgh85TufjyUjfYD61sVLjpLA7VuGbMFGSfjdoTjf9UFh1sner/ 4gaUZKn97zWgjRXdWuRCHbN0RoCgeGOmmb2VD3IwT+Cth+BaOQQqX3w3jfTMrU6mxVomKpY Lzu2dkYyg48/XNocpUeZA== UI-OutboundReport: notjunk:1;M01:P0:TATdpF1BgzY=;CSoP0DSOvJhTtkqrTAHJT79XkyF awtlA0KQ9NGmoqeh5mbS7+nGJch26B82Dx69fmRuY1Zbbz4Bp9s/sZ7wArulHkCwlw5bfsXMO fyVO0O09lgDLZENgcVtPXC4snB5GVJK82frHvveWyj9iHAxclWAQwe4OOp0pJ8IS5G+ZXKDZp jMPfwUsae91rEUQ/peQ5s9gsDXk+vgT9ALZSq/GTGqv9pNJXFX5doD5N0cow00XweoRBE9j8L ubOXch79cYEVZPrAxSrEcWfZqEQ5nLUtGsSX7FGktMbp/nBT2gUuIP8D7DCaef8IK4CxmBIx3 6enM6//i7lkY/8SDi22iDq5g4FkTUbicR9bCZEBsZ9hKPko2kVwrvDFpFGkFKNq5fZYGFRE3y VLKd+7ev2n4rNryIl9BNGPS/G36dLxGow8+NF915YaS/GB48X/rZ2EUYrHnHDYX7Qxa1J02vG smU9PpsGKs9Lr43hdkP52WHFavkfOQacbAkcTa5tdOi7ofhU1MTWjLqsQuDhns5NxDVwNcHkw rj4XHQQR1uaFg9WX3Bo9OIjLWlVHoMKQnpoKH0/AnpPyoZUYCreT0jKysOIxlzlJ1pbFs2om7 IfnX4lFooj1dti0t/YToKO8hYRKEybxwVJSVjBk2wIHfBenxj39Wrx7MX+X1hS2itsCApxrBg wanvDaAF32zlPeA8K3jaDjdfDeszrgPtjEMoLXM5F/EU9h3J7NEVE9ICXjbzEewq/UL22JHyc vPv48TltTL9ObJSfWXADymOyRyO7Jzhz/r1xOATN/tl+xYoNKu1PCvw8Cl03MI2XEv9OuUaw Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306567 Archived-At: Ihor Radchenko writes: > Do you refer to > (add-function :before (local 'isearch-filter-predicate) #'foo) > ? Yes. > Two reasons: > 1. I only vaguely understand how this works This can be changed. Should. > 2. It feels against the interface. If advising this predicate is > expected, why not convert it into an abnormal hook? It's more flexible and expressive, as Drew already mentioned. For example, how the members of a hook are logically combined (`and'ed, `or'ed) is fixed in a hook, but not when using advising. I also wonder about the `kill-variable' calls: what if the user or a third-party mode want to have own buffer-local settings for these? We then erase them when killing the local variables. With using an advice on these the worst thing that could happen is that we leave a buffer local variable with the same binding as the global one, where we started with no buffer local binding. Michael.