From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Sun, 18 Jun 2023 04:48:01 +0200 Message-ID: <87o7ld32qm.fsf@web.de> References: <875y8nks9t.fsf@localhost> <87fs7c10cq.fsf@web.de> <87v8g79zoe.fsf@localhost> <87sfbasr8m.fsf@web.de> <87y1l244hz.fsf@localhost> <87o7lxpip9.fsf@web.de> <87wn0lkkod.fsf@localhost> <87leh02iqx.fsf@web.de> <87ttv69r2n.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5915"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:2p+gnDP2tdKzewGqnYqO1Sqx8VI= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 18 04:48:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAiSu-0001Jy-2j for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Jun 2023 04:48:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAiSb-0001HQ-43; Sat, 17 Jun 2023 22:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAiSZ-0001HH-Qe for emacs-devel@gnu.org; Sat, 17 Jun 2023 22:48:11 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAiSY-0006YP-9o for emacs-devel@gnu.org; Sat, 17 Jun 2023 22:48:11 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qAiSW-0000n1-6s for emacs-devel@gnu.org; Sun, 18 Jun 2023 04:48:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306905 Archived-At: Ihor Radchenko writes: > >> May you please elaborate? I am not sure what `kill-variable' calls you > >> are referring to here. > > > > To those in `wdired-change-to-dired-mode: > > > > #+begin_src emacs-lisp > > (when wdired-search-replace-filenames > > (remove-function (local 'isearch-search-fun-function) > > #'dired-isearch-search-filenames) > > (kill-local-variable 'replace-search-function) > > (kill-local-variable 'replace-re-search-function) > > ;; Restore dired hook > > (add-hook 'isearch-mode-hook #'dired-isearch-filenames-setup nil t)) > > #+end_src > > > > This demonstrates a problem when not using an advice: to get rid of the > > temporary new binding you simply kill the local variable, but this can > > be problematic, especially when we did not create it (but maybe someone > > third). > > The code above is indeed slightly problematic. > I'd store the old value somewhere in such situations and restore later. Now I'm a bit confused. Is advising not exactly the perfect solution for that problem because it allows to avoid explicit saving and restoring (which is one reason why I'm suggesting to use advising, plus: overlapping modification and restore operations don't collide), and: > May `define-advice' be modified to work on variable values? That way, > one can override the variable value and later restore the old one using > the existing machinery. What's wrong with `add-function' and `remove-function' (which work on variable values)? Seems you misunderstood what I'm suggesting, or you misunderstand how advising works. Michael.