From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/helm 07dacfe2e2 08/11: Prefer string-match-p over string-suffix-p Date: Thu, 14 Sep 2023 16:21:18 +0000 Message-ID: <87o7i4ohdt.fsf@posteo.net> References: <169468919249.10884.8856179202519044902@vcs2.savannah.gnu.org> <20230914105954.20BD1C051D0@vcs2.savannah.gnu.org> <875y4dosa4.fsf@posteo.net> <83wmwslxlc.fsf@gnu.org> <87wmwsoqe0.fsf@posteo.net> <83ttrwlwy5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, thievol@posteo.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 14 18:22:44 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgp75-0007lG-CA for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Sep 2023 18:22:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgp63-0001mG-4D; Thu, 14 Sep 2023 12:21:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgp62-0001m2-2W for emacs-devel@gnu.org; Thu, 14 Sep 2023 12:21:38 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgp5m-0006In-6F for emacs-devel@gnu.org; Thu, 14 Sep 2023 12:21:37 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E4790240029 for ; Thu, 14 Sep 2023 18:21:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694708478; bh=hrU9lvNl8befyX2g52kNdU8ROklmkt4sIRwahVSKZv4=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=ixqw6CTpSOrxyL+NKaOM4fWEjJDqq83ZuuFvGiIYd9XDThB4wr15P4J+ccGtH2TbA 82/bgvNGUjY4QUhYSo5u8sQJiUfB8Np37KlGG9OCx7JKyMsOfaN+tYJpK6pg8JhcHD SmSmxv6Q3kSPjK7aFD0P5IKo+/ZWCABcd8Dc1+IBVat/3E+behhgoap0BVqgcar7Ys K/HCrtEtgjg5ulioM7dhQ+5YhuWldI4Au0dICIzxNEz23ahktflXpniE4g+40LaMyX U0UpZi1iVF0hIL9TN90t1Y4g8BJGuxd6pOCLh0pem9ghNag9RIgU86ABoOVxtlAbwv yDOiUwEGmWO7A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RmjHf3MR4z6ty5; Thu, 14 Sep 2023 18:21:18 +0200 (CEST) In-Reply-To: <83ttrwlwy5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Sep 2023 16:13:22 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310579 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: emacs-devel@gnu.org, thievol@posteo.net >> Date: Thu, 14 Sep 2023 13:06:47 +0000 >> >> Eli Zaretskii writes: >> >> > I think this change is simply incorrect: the first argument of >> > string-suffix-p is not interpreted as a regexp, but as a simple >> > literal string (the implementation uses compare-strings internally). >> >> But why is it incorrect? `string-suffix-p' is passed a string, while >> `string-match-p' takes a regular expression, that might be too liberal >> but should still match everything the previous check did -- or am I >> missing something? > > Why do the change when string-suffix-p already ensures there's nothing > in the second argument after the suffix? I don't know, that is what I wanted to ask Thierry.