From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Tomas Hlavaty <tom@logand.com>
Newsgroups: gmane.emacs.devel
Subject: Re: Instead of pcase
Date: Thu, 16 Nov 2023 21:16:01 +0100
Message-ID: <87o7ftlaim.fsf@neko.mail-host-address-is-not-set>
References: <E1r3SgH-0007Rb-BU@fencepost.gnu.org>
 <iery1exiv1q.fsf@janestreet.com>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="34773"; mail-complaints-to="usenet@ciao.gmane.io"
To: Spencer Baugh <sbaugh@janestreet.com>, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 16 21:16:55 2023
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1r3inH-0008pa-7Q
	for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Nov 2023 21:16:55 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1r3imo-0004Nm-By; Thu, 16 Nov 2023 15:16:28 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tom@logand.com>) id 1r3imf-0004Lk-Qx
 for emacs-devel@gnu.org; Thu, 16 Nov 2023 15:16:18 -0500
Original-Received: from logand.com ([37.48.87.44])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tom@logand.com>) id 1r3imd-0001TQ-9y
 for emacs-devel@gnu.org; Thu, 16 Nov 2023 15:16:17 -0500
Original-Received: by logand.com (Postfix, from userid 1001)
 id C2C4C19E77E; Thu, 16 Nov 2023 21:16:03 +0100 (CET)
X-Mailer: emacs 28.2 (via feedmail 11-beta-1 I)
In-Reply-To: <iery1exiv1q.fsf@janestreet.com>
Received-SPF: pass client-ip=37.48.87.44; envelope-from=tom@logand.com;
 helo=logand.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:312837
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/312837>

On Thu 16 Nov 2023 at 10:20, Spencer Baugh <sbaugh@janestreet.com> wrote:
> (let ((exp (if t '(foo . "str") '(bar . 7))))
>   (pcase exp
>     (`(foo . ,val) (concat "str" val))
>     (`(bar . ,val) (+ 1 val))))

(`(foo . ,val) (concat "str" val)) looks very strange.
One does not write (let ((,val ...)) ...).

Maybe (('foo . val) (concat "str" val)) would make more sense?

> and with cond-let one could write:
>
> (let ((exp (if t '(foo . "str") '(bar . 7))))
>   (cond-let
>    ((val
>      (and (eq (car exp) 'foo) (cdr exp)))
>     (concat "str" val))
>    ((val
>      (and (eq (car exp) 'bar) (cdr exp)))
>     (+ 1 val))))
>
> Which is maybe nicer?

(let ((exp (if t '(foo . "str") '(bar . 7))))
  (cl-case (car exp)
    (foo
     (when-let ((d (cdr exp)))
       (concat "str" val)))
    (bar
     (when-let ((d (cdr exp)))
       (1+ val)))))

It is a shame that case, ecase, typecase and etypecase are (were moved?)
to cl-lib.