unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Emacs development discussions." <emacs-devel@gnu.org>
To: Arthur Miller <arthur.miller@live.com>
Cc: emacs-devel@gnu.org
Subject: Re: Compiling in mingw-ucrt runtime
Date: Thu, 22 Feb 2024 14:24:52 +0800	[thread overview]
Message-ID: <87o7c96mob.fsf@yahoo.com> (raw)
In-Reply-To: <DU2PR02MB10109B23C0097A9BE29DCF7AE96562@DU2PR02MB10109.eurprd02.prod.outlook.com> (Arthur Miller's message of "Thu, 22 Feb 2024 01:01:17 +0100")

Arthur Miller <arthur.miller@live.com> writes:

> diff --git a/src/sysdep.c b/src/sysdep.c
> index 3a6829dd27a..5d294ca1bdf 100644
> --- a/src/sysdep.c
> +++ b/src/sysdep.c
> @@ -2981,7 +2981,7 @@ close_output_streams (void)
>    fflush (stderr);
>    fflush (stdout);
>  #else /* !__ANDROID__ */
> -  if (close_stream (stdout) != 0)
> +  if (close_stream (stdout) != 0 && errno && (errno != EINTR))
>      {
>        emacs_perror ("Write error to standard output");
>        _exit (EXIT_FAILURE);
> @@ -2993,7 +2993,10 @@ close_output_streams (void)
>    if (err | (ADDRESS_SANITIZER
>  	     ? fflush (stderr) != 0 || ferror (stderr)
>  	     : close_stream (stderr) != 0))
> -    _exit (EXIT_FAILURE);
> +    {
> +      if (errno && (errno != EINTR))
> +	_exit (EXIT_FAILURE);
> +    }
>  #endif /* __ANDROID__ */
>  }
>  \f

Why is this change necessary to build Emacs with a previously
unsupported C library?  If it is, shouldn't whatever problem it
circumvents be addressed in Gnulib (which provides close_stream), and
not in Emacs?



  reply	other threads:[~2024-02-22  6:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  0:01 Compiling in mingw-ucrt runtime Arthur Miller
2024-02-22  6:24 ` Po Lu via Emacs development discussions. [this message]
2024-02-22  7:14 ` Eli Zaretskii
2024-02-23  7:58   ` Arthur Miller
2024-02-23  8:24     ` Eli Zaretskii
2024-02-23 11:32       ` Arthur Miller
2024-02-23 12:02         ` Eli Zaretskii
2024-02-24  9:13           ` Arthur Miller
2024-02-24 10:24             ` Eli Zaretskii
2024-02-24 23:11               ` Arthur Miller
2024-02-25  5:56                 ` Po Lu
2024-02-25  6:33                 ` Eli Zaretskii
2024-02-25 10:19                   ` Arthur Miller
2024-02-25 10:48                     ` Eli Zaretskii
2024-02-25 11:40                       ` Arthur Miller
2024-02-25 12:15                         ` Eli Zaretskii
2024-02-25 14:11                           ` Bruno Haible
2024-02-25 14:29                             ` Eli Zaretskii
2024-02-25 15:05                               ` Bruno Haible
2024-02-25 15:14                                 ` Eli Zaretskii
2024-02-25 15:32                                   ` Bruno Haible
2024-02-25 16:02                                     ` Eli Zaretskii
2024-04-02 15:30                                       ` Arthur Miller
2024-04-02 16:28                                         ` Eli Zaretskii
2024-04-03 13:09                                           ` Arthur Miller
2024-02-23 14:47 ` Benjamin Riefenstahl
2024-02-23 15:03   ` Benjamin Riefenstahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7c96mob.fsf@yahoo.com \
    --to=emacs-devel@gnu.org \
    --cc=arthur.miller@live.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).