Re: master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix.

Re: master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix.

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> +widgets; kill all xwidget-webkit buffers for changes in this setting
> +to take effect.  */);

But this isn't true: the changes will take effect in new WebKit widgets
whether or not some widgets already exist with a different value of this
setting.

Re: master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix.

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 15 Mar 2024 19:12:03 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > +widgets; kill all xwidget-webkit buffers for changes in this setting
> > +to take effect.  */);
> 
> But this isn't true: the changes will take effect in new WebKit widgets
> whether or not some widgets already exist with a different value of this
> setting.

Feel free to rephrase, but please do NOT lose practical information,
which is important to users, and without which that part of the doc
string is basically useless.  We must tell users what to do after they
change the value of the variable, for the doc string to be of any use.

(And in the future, may I suggest that you discuss your changes that
remove useful information, before going ahead and silently making
unilateral changes like this one?  Not only will it be more polite, it
will also lower the probability of letting less-than-useful doc
strings slip past us into the release.)