From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Herman=2C_G=C3=A9za?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Implement fast verisons of json-parse functions Date: Mon, 01 Apr 2024 18:54:25 +0200 Message-ID: <87o7atm33y.fsf@gmail.com> References: <87h6h2rsgn.fsf@gmail.com> <867chy3vpm.fsf@gnu.org> <87cyrqrqnb.fsf@gmail.com> <865xxi3tsu.fsf@gnu.org> <874jd2rnwj.fsf@gmail.com> <864jd14lqs.fsf@gnu.org> <87edc1rzig.fsf@gmail.com> <865xx4dv0g.fsf@gnu.org> <871q7snffr.fsf@gmail.com> <86plvbdgcx.fsf@gnu.org> <87wmpjmsie.fsf@gmail.com> <86zfufasz6.fsf@gnu.org> <60B7A2FC-93BC-4759-91EE-DEE179009142@gmail.com> <864jcmbe4f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17605"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , geza.herman@gmail.com, emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 01 18:59:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrL0S-0004Jd-NM for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Apr 2024 18:59:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrKzl-0006Ya-2X; Mon, 01 Apr 2024 12:58:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrKzj-0006Xu-77 for emacs-devel@gnu.org; Mon, 01 Apr 2024 12:58:51 -0400 Original-Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrKzg-0002fV-SL; Mon, 01 Apr 2024 12:58:50 -0400 Original-Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2d6ff0422a2so59143111fa.2; Mon, 01 Apr 2024 09:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711990726; x=1712595526; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:from:to:cc:subject:date:message-id :reply-to; bh=LDwqRU1t/npKScjOgDYnAv6CukfHs/N/L80xOH6FVwc=; b=aoE/HqAJwR9dTurfO4Ph0yXaWK/ptWiURzlR/ne0+QY6qI4zLttu5Dx8ogcJVfBcQ4 a9vM7WfOJKhBN4RvDMeCpejl6B8I2HOpX8X5SHSoz5NNDkVSDewWiYD4jsHBpU9UEE9T /lzlfAwr3EhtZaXKuFni0J7yXTVz9aB4ngw+5m380PhP5t/Ycah6FfMSXd45P6ErHBi6 7qB9uxAXSkyTxZ4YyZB8Tws7u5g+xfI1tV2WKs9kznkV9/8NnkbFIS2z46LfmpWO8AXy wFoDENc3uVsno6UJZjQqGt/4+dn81O7GgqbzYSW+krD/PImcqTtC+xhZ7B1wbb8ylJ4l jObQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711990726; x=1712595526; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LDwqRU1t/npKScjOgDYnAv6CukfHs/N/L80xOH6FVwc=; b=KxXveqncjl2amKeBXfEZIL/YyefZzOw0LxGNXOblIC4d9BZyMaWN3lNiFuKnZRlQGL QO26xVsbqDvDtEDvPdI/jXcFkvKk1ssODRrb06JysbhDm9eLtbj1VHn64ZdxKUPZP0H4 1YvSzCe8zL91EHhfzgMWUHe9daLsxz/AT6avwO0t6e6IkWdC6ydc9CzP4MujMdlu6SXa tvZCPKY3ZtbU3zH7e2GFnpIluK3zYF/DzbUzTMXCYGkTzKwWbET6ZBBbJfJtcZ/5Y81I 5A4WoMY68m/xhLaxV1Zd1sPC4q4FxXjRW1qO27qGoCzGVvfu8PmgtNaU4g0V79vgP6jz W0FA== X-Forwarded-Encrypted: i=1; AJvYcCWDHXDnRpREyCMfh2VioOoQyuoNhw+9TrLqv1kPOxzRQbZ6OOI9hFPFw+85anq8w8dRkeLm/zjs1bNQYkW0jdSB0DTG X-Gm-Message-State: AOJu0YzUGFx+9B7Rzd+95Xnrj0YWcwepJmPxYhP6pITXM5Lzrj8j7jXR QRtN+9V4g1wZzhS8n8Q2uCLxK+gC9q+RyguxzBMR/423xaWunGLcnQe9EARW X-Google-Smtp-Source: AGHT+IF98k4I6ZlWjuRLPB75/wlpuGLForYKkd5pfnuaLzQin4g+T6j2M010LMnUr8DNUvwk/5miBA== X-Received: by 2002:a2e:804a:0:b0:2d2:6193:6d53 with SMTP id p10-20020a2e804a000000b002d261936d53mr5999565ljg.13.1711990725798; Mon, 01 Apr 2024 09:58:45 -0700 (PDT) Original-Received: from localhost (netacc-gpn-104-145-196.pool.yettel.hu. [91.104.145.196]) by smtp.gmail.com with ESMTPSA id jb2-20020a05600c54e200b004155387c08esm10480357wmb.27.2024.04.01.09.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 09:58:45 -0700 (PDT) In-reply-to: Received-SPF: pass client-ip=2a00:1450:4864:20::235; envelope-from=geza.herman@gmail.com; helo=mail-lj1-x235.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317451 Archived-At: Mattias Engdeg=C3=A5rd writes: > 31 mars 2024 kl. 17.44 skrev Eli Zaretskii : > >> I'm okay with changing the errors we signal, but let's please=20 >> document >> in NEWS all the changes in this area. > > Right. The new code is now in master. > It made for a parsing speed-up of about 2x, often more. > > I also fixed the unintuitive `end-of-file` errors from=20 > (json-parse-string "\0"). It had nothing to do with NULs,=20 > actually. Nice, thank you! Are there any problems remaining that may some=20 help from me?