From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view) Date: Tue, 16 Apr 2024 07:24:42 +0000 Message-ID: <87o7a9lqh1.fsf@posteo.net> References: <87a5oayblv.fsf@gmail.com> <87jzlxro68.fsf@localhost> <87zfu6b4w3.fsf@gmail.com> <86jzl91zrd.fsf@gnu.org> <87frvwl2wv.fsf@gmail.com> <87plv02rez.fsf@posteo.net> <87cyqzllbx.fsf@gmail.com> <87o7ahmxnj.fsf@posteo.net> <87msq12blu.fsf@gmail.com> <87cyqwmmkb.fsf@posteo.net> <87v84l3bfx.fsf@posteo.net> <87wmoy94wc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39035"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org To: =?utf-8?Q?S=C5=82awomir?= Grochowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 16 09:25:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwdCH-0009s7-FR for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Apr 2024 09:25:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwdBU-0002ml-PI; Tue, 16 Apr 2024 03:24:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwdBS-0002mX-NX for emacs-devel@gnu.org; Tue, 16 Apr 2024 03:24:50 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwdBO-00054u-KP for emacs-devel@gnu.org; Tue, 16 Apr 2024 03:24:49 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 10A4D240029 for ; Tue, 16 Apr 2024 09:24:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713252284; bh=zWqsfp69k5XVv0exZhCus70iDVxwSttAo8tNczDRyCE=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=UuoNibsl2FJkpDJiCg6Z7LYUdCr+lJX58iNTdwYg214AaNtsth1wKdwh+UHza6GW+ PN2O7Es+7h/7QtrCKoYriVwNZvMvCB2yjidYdWXUFbQP8Gpd23tMhz4ByMB6fgetg1 kTx1UphCND9YXaVz9m+eIIwgJez8s2ySI0btyvAnQYg98seeWcU6M66cTtH7mYkxQr g1dWsdPPOlShbHzFZz/2S/v0bKt0nA3p41Vx4kt2uZLx4aQhnPEFUhG/LiI1NtyL5y PTaC/K4ggvYj/H5xyIjP1rjBBiumrd8sWrR2013TsXwy86CiQefgzU4ARiSUjnR9qI oNXin6J9KA9GA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VJbCH0lSQz6tvy; Tue, 16 Apr 2024 09:24:42 +0200 (CEST) In-Reply-To: <87wmoy94wc.fsf@gmail.com> (=?utf-8?Q?=22S=C5=82awomir?= Grochowski"'s message of "Mon, 15 Apr 2024 14:39:15 +0200") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317746 gmane.emacs.orgmode:161073 Archived-At: S=C5=82awomir Grochowski writes: > Philip Kaludercic writes: >> I have pushed the changes to master. > > Thank you Philip for your help. It works. > > But there is one more small thing.=20 > A message that is displayed in the minibuffer.=20 > It contains two pieces of information: > > (1) command name > Right now it's hardcoded.=20 > We need to change the it from `help-quick-toggle' to > `org-columns-help-quick-toggle'. > How to do it?=20 > Add another variable like `help-quick-use-map'? > Maybe 'help-quick-command-name'? Instead of using substitute-command-keys, we could just use this-command, but that assumes that help-quick can always be toggled by the command that invokes it. > (2) keybinding to the command name > Just to modify message string. Add '\\'. > To use other keymap. > Change is in the diff below.=20 I don't see how this would work in general, at the very least it breaks the regular usage. Furthermore, I am not convinced we have to change anything here, since C-h C-q (the default binding for `help-quick-toggle') should also hide the buffer if one uses your command, or am I mistaken? > > diff --git a/lisp/help.el b/lisp/help.el > index d4e39f04e53..35412b9d2fe 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -263,7 +263,9 @@ help-quick > ;; ... and shrink it immediately. > (fit-window-to-buffer)) > (message > - (substitute-command-keys "Toggle display of quick-help buffer using= \\[help-quick-toggle].")))) > + (substitute-command-keys "Toggle display of quick-help buffer using= \\ \\[org-columns-help-quick-toggle].")))) > + > + >=20=20 > (defun help-quick-toggle () > "Toggle display of a window showing popular commands and their binding= s. > --=20 > > 2.30.2 > > > Regards, --=20 Philip Kaludercic on peregrine