From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Start of Emacs 30 release cycle Date: Tue, 25 Jun 2024 17:09:48 +0200 Message-ID: <87o77p9hz7.fsf@gmail.com> References: <86frt3eptb.fsf@gnu.org> <8734p2212i.fsf@gmx.net> <86jziebj8j.fsf@gnu.org> <87pls6zc0r.fsf@rub.de> <86cyo6bcub.fsf@gnu.org> <87y16t485d.fsf@gmx.net> <87sex19kq1.fsf@gmail.com> <87pls53wok.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29987"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , maurooaranda@gmail.com, emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 25 17:12:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sM7qo-0007cW-02 for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jun 2024 17:12:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sM7nx-00021k-49; Tue, 25 Jun 2024 11:09:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sM7nv-0001uB-8S for emacs-devel@gnu.org; Tue, 25 Jun 2024 11:09:55 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sM7nt-0006aE-Jy; Tue, 25 Jun 2024 11:09:55 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-424720e73e1so46107695e9.1; Tue, 25 Jun 2024 08:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719328191; x=1719932991; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=onidzRMHFmR+dvy2SM0hoaLe7kF3g6QoHmhWAGUxcKE=; b=UM/QVYqNU+j0iKTF59DZi9HrxR9KrWadYaBDVDHirfpw5HV83UrzJBFDHCesbkXgvA AVK+YJZOySSFr7PKBwsy3f+ZhhKHVmZgVxCZna8+qFqybnd0TB+t+LKeHR6wFUF/BDED Shk51RhEDaPmahb3JtPL6dj6ajdRuDGWE3M7X8nkQ6kY6IYRplYQHoTNMSW/KeJ9Dsd+ ZhwoOoUzCXIq1x9i6jC7soc4b+OHlkHJsn9/7SRnaoNn/gNM3TOvGDUwsqk1AKEiQPFl GkpfSg5LemUvPhnOvAph6VFmcp6SpKGTOjHSTFXw6Dm1PggcXMp0BP1rB50oLdUF/h7r kzEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719328191; x=1719932991; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=onidzRMHFmR+dvy2SM0hoaLe7kF3g6QoHmhWAGUxcKE=; b=W6u+SnvEuLyQpBRsejuOEjpalrUtAPilbI0U22J6Tj0BakS2wKMAP0VRpViefNu3p+ 5ON9AjyDKkgaoE7jnBXulFaZ/kIpRjZosy0oz0KfwapzxUtWqmI3YgKYY7zwtYglkEXl Tl3SE3xoKiIQ0Nm3lvwrWNKinR9IAoVJmBr0m+DOOd28iXPVA/k5slpbxKGn09ZLRBJq PkW6ZDv7x5VHM6FWzpc14LoMyXwALIeGPjleClTRgJHnZjLvIijfpvMiy8xrQohB8TAc vHxKo4kP/TeE0+XyJgKL7ylYjnCBDudWUM+GLWsH2bxRsS+1lHuD39BST5tTakjjnVfj RKJA== X-Forwarded-Encrypted: i=1; AJvYcCUMN/gAOggQESIB6qVzr8o+1l2xVJOT3YmTqgoyZSXlwqUlpPYS6AC3HdVsI9Lo/XlYLpQ2VfFsMHckBGTtZsX/GGqV X-Gm-Message-State: AOJu0YySDkSjunZElEz89KeEd2r1BPNWAe2ugXYk/JLaO7plaWLQfQmX bHz+LO1xBQQfPweVnuwJoKvrAEQin9Ybdw3cpjKiuvK4mnFhTjrL3LOuew== X-Google-Smtp-Source: AGHT+IGhLkEhdaFvIInHOQsDd8eS7Ltjoe9HT0+aCHD6Qb7WWgHysKid37WjXpukHWvGFJx5yboWpw== X-Received: by 2002:a5d:5223:0:b0:362:def2:3949 with SMTP id ffacd0b85a97d-366e952b455mr4339184f8f.22.1719328190757; Tue, 25 Jun 2024 08:09:50 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663a8c8f50sm13121045f8f.109.2024.06.25.08.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 08:09:49 -0700 (PDT) In-Reply-To: <87pls53wok.fsf@gmx.net> (Stephen Berman's message of "Tue, 25 Jun 2024 16:48:43 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320636 Archived-At: >>>>> On Tue, 25 Jun 2024 16:48:43 +0200, Stephen Berman said: Stephen> On Tue, 25 Jun 2024 16:10:30 +0200 Robert Pluim wrote: >>>>>>> On Tue, 25 Jun 2024 12:41:02 +0200, Stephen Berman >> said: Stephen> Yes, indeed. Is the attached complete patch ready to install = in Stephen> emacs-30? >>=20 >> Minor comments below (although globally I=CA=BCd say you=CA=BCre ove= rriding the >> .dir-locals.el setting for `indent-tabs-mode', which is why the diffs >> look funny) Stephen> I haven't changed indent-tabs-mode: its global value is the de= fault t Stephen> but in buffers under emacs/lisp nil. And the diffs don't look= funny to Stephen> me; how do they look funny to you? eg this hunk: (defsubst widget-type (widget) @@ -2452,10 +2475,16 @@ 'checkbox (defun widget-checkbox-action (widget &optional event) "Toggle checkbox, notify parent, and set active state of sibling." (widget-toggle-action widget event) - (let ((sibling (widget-get-sibling widget))) + (let* ((sibling (widget-get-sibling widget)) + (from (widget-get sibling :from)) + (to (widget-get sibling :to))) There=CA=BCs a tab on the line for 'to', but the line for 'from' uses space= s. Robert --=20