From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: eldoc-diffstat Date: Sun, 15 Dec 2024 10:11:42 +0000 Message-ID: <87o71ds1b5.fsf@posteo.net> References: <87y10osimb.fsf@jklaehn.de> <87r06b72oe.fsf@gnu.org> <87cyhuaqun.fsf@jklaehn.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17685"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , Tassilo Horn , emacs-devel@gnu.org To: Johann =?utf-8?Q?Kl=C3=A4hn?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 15 11:12:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMlcI-0004Qy-OD for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Dec 2024 11:12:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMlbN-00023w-IP; Sun, 15 Dec 2024 05:11:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMlbK-00023O-0u for emacs-devel@gnu.org; Sun, 15 Dec 2024 05:11:50 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMlbH-0007Z3-5Z for emacs-devel@gnu.org; Sun, 15 Dec 2024 05:11:49 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6178E240027 for ; Sun, 15 Dec 2024 11:11:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734257503; bh=dngOGfeYbvSu+dPQ+FcijjqICVg8Qph3sxZr/N2Uztw=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=mYptwnr/kU3FrpaKJnkVDaJYSLO8zEQVrS9KsBpKBT7tQvIjt/mSky1dtaQfWw4p5 8mDcgxlzhJuS6oe3UfRUVn9/K8xG3R3op5gzGT/Pu0UGUirNKCkeAtVDye61IvLwdr DKNrOrTg9MYaq5T9whgwm/5QXU0xUwnn/fkXnzXlkHMgT1DNaFQibYIGiV7Rg+RWvD g8dFEKXUw4b6zYSN/Dl3lPwINYHCL85+a1pkdPr3Luh9C4efkaPGY8JlWAINVUtjr9 MHHTqe+4Zy2uww9WEJiIac0tMwc3N5pGj05MLL30MrugXhXc16Sl4Oh7M/6j/XMv4h Vafnn6GrfT9yA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y9zPp4m05z9rxK; Sun, 15 Dec 2024 11:11:42 +0100 (CET) In-Reply-To: <87cyhuaqun.fsf@jklaehn.de> ("Johann =?utf-8?Q?Kl=C3=A4hn=22'?= =?utf-8?Q?s?= message of "Sat, 14 Dec 2024 22:37:20 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326523 Archived-At: Johann Kl=C3=A4hn writes: > Thanks for your comments, everyone! [...] > On Sat, Dec 14, 2024 at 10:11 +0000, Philip Kaludercic wrote: >> '((Git "git" "--no-pager" "show" "--color=3Dalways" >> - "--format=3Dformat:%an <%ae>, %aD:%n%s" "--stat=3D80") >> + "--format=3Dformat:%an <%ae>, %aD:%n%s" "--stat=3D80") > > Some lines look like spurious whitespace changes? I hope I picked out > all functional changes. That is true, my apologies. >> + ;; Is it an issue that there is the slight possibility of a race >> + ;; condition here? > > I happened to have the same thought yesterday, also w.r.t. the > sentinel function. As far as I see, there is no way of avoiding this without extending `make-process' to accept a process plist (which wouldn't be backwards compatible). But if you don't insist on using the process plist, you could capture the revision info in a closure and pass it on to the sentinel. >> The rewriting of >> `eldoc-diffstat--format-output-buffer' might be controversial, but I >> feel that using a regular expression to destruct the buffer feels more >> robust. > > Yes, probably. Though I decided to keep the original output if the > regex fails to match, as it might help users figure out what's happening. That's fine as well of course!