From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Faces for Mode Line and Mode Line Inactive Date: Sun, 05 Dec 2004 18:17:19 -0500 Message-ID: <87mzws2v7l.fsf-monnier+emacs@gnu.org> References: <006d01c4da5e$bd51eb60$0200a8c0@sedrcw11488> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1102288666 11495 80.91.229.6 (5 Dec 2004 23:17:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Dec 2004 23:17:46 +0000 (UTC) Cc: Lennart Borgman , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 06 00:17:38 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Cb5dK-0005x7-00 for ; Mon, 06 Dec 2004 00:17:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cb5n3-00012E-6O for ged-emacs-devel@m.gmane.org; Sun, 05 Dec 2004 18:27:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Cb5mj-000128-Dh for emacs-devel@gnu.org; Sun, 05 Dec 2004 18:27:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Cb5mj-00011w-0X for emacs-devel@gnu.org; Sun, 05 Dec 2004 18:27:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cb5mi-00011t-U5 for emacs-devel@gnu.org; Sun, 05 Dec 2004 18:27:20 -0500 Original-Received: from [209.226.175.184] (helo=tomts22-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cb5co-00089w-Bd; Sun, 05 Dec 2004 18:17:06 -0500 Original-Received: from alfajor ([67.68.219.169]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20041205231705.SJWO1919.tomts22-srv.bellnexxia.net@alfajor>; Sun, 5 Dec 2004 18:17:05 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 50908D73CB; Sun, 5 Dec 2004 18:17:19 -0500 (EST) Original-To: John Paul Wallington In-Reply-To: (John Paul Wallington's message of "Sun, 05 Dec 2004 22:45:34 +0000") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30726 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30726 > Index: faces.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v > retrieving revision 1.293 > diff -u -r1.293 faces.el > --- faces.el 2 Dec 2004 10:56:05 -0000 1.293 > +++ faces.el 5 Dec 2004 22:21:30 -0000 > @@ -1786,16 +1786,16 @@ > :group 'basic-faces) > (defface mode-line-inactive > - '((t > - :inherit mode-line) > - (((type x w32 mac) (background light) (class color)) > + '((((type x w32 mac) (background light) (class color)) > :weight light > :box (:line-width -1 :color "grey75" :style nil) > :foreground "grey20" :background "grey90") > (((type x w32 mac) (background dark) (class color)) > :weight light > :box (:line-width -1 :color "grey40" :style nil) > - :foreground "grey80" :background "grey30")) > + :foreground "grey80" :background "grey30") > + (t > + :inherit mode-line)) > "Basic mode line face for non-selected windows." > :version "21.4" > :group 'modeline Please read the NEWS file. You'll discover that the above patch changes the behavior. The current code unconditionally inherits from mode-line whereas your change make it inherit only for things like ttys or b&w displays. Stefan