From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: New undo element (fun . args) Date: Wed, 02 Feb 2005 09:35:23 -0500 Message-ID: <87mzunvyki.fsf-monnier+emacs@gnu.org> References: <87fz0jyn19.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1107355492 23971 80.91.229.2 (2 Feb 2005 14:44:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 2 Feb 2005 14:44:52 +0000 (UTC) Cc: miles@gnu.org, snogglethorpe@gmail.com, emacs-devel@gnu.org, "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 02 15:44:51 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1CwLjh-0002Ua-82 for ged-emacs-devel@m.gmane.org; Wed, 02 Feb 2005 15:44:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CwLvg-0000Bs-Ax for ged-emacs-devel@m.gmane.org; Wed, 02 Feb 2005 09:56:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CwLvB-00005o-GI for emacs-devel@gnu.org; Wed, 02 Feb 2005 09:55:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CwLv9-00004x-Ts for emacs-devel@gnu.org; Wed, 02 Feb 2005 09:55:56 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CwLv9-00004u-QS for emacs-devel@gnu.org; Wed, 02 Feb 2005 09:55:55 -0500 Original-Received: from [209.226.175.74] (helo=tomts20-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CwLbN-0002zy-Bo; Wed, 02 Feb 2005 09:35:29 -0500 Original-Received: from alfajor ([67.71.119.41]) by tomts20-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050202143523.JXMW2034.tomts20-srv.bellnexxia.net@alfajor>; Wed, 2 Feb 2005 09:35:23 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 2CBDF2FD49; Wed, 2 Feb 2005 09:35:23 -0500 (EST) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Wed, 02 Feb 2005 02:28:17 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:32757 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:32757 > One of the undoable operations in SES is setting a variable. > This doesn't relate directly to buffer text, but it might > be associated with some region somehow. I don't know > how this is used, and I think it is important to check. Most of the vars that are thus set/unset are vars of the form "B6" or "C20", i.e. vars that hold the content of a cell. So they do have some relation with one specific region of the buffer: the corresponding cell. So we could just replace (apply ses-set-with-undo ,sym ,(symbol-value sym)) with (apply START END 0 ses-set-with-undo ,sym ,(symbol-value sym)) where START and END are the boundaries of the cell. But since the same code is used for other vars as well, such as vars that relate to a particular column of the spreadsheet, it'll take a bit more effort. Stefan