From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.gnus.semi.japanese,gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Changes in calendar/time-date.el Date: Mon, 04 Apr 2005 12:57:32 +0200 Message-ID: <87mzsezu5f.fsf@xs4all.nl> References: <871x9w9dkn.fsf@xs4all.nl> Reply-To: semi-gnus-ja@meadowy.org NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1112612246 31220 80.91.229.2 (4 Apr 2005 10:57:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2005 10:57:26 +0000 (UTC) Cc: emacs-devel@gnu.org, ding@gnus.org, semi-gnus-ja@meadowy.org, Miles Bader Original-X-From: semi-gnus-ja-return-12946-gegsj-semi-gnus-ja-403=m.gmane.org@meadowy.org Mon Apr 04 12:57:24 2005 Return-path: Original-Received: from meadow.scphys.kyoto-u.ac.jp ([130.54.54.165]) by ciao.gmane.org with smtp (Exim 4.43) id 1DIPGO-0004ff-Cc for gegsj-semi-gnus-ja-403@gmane.org; Mon, 04 Apr 2005 12:57:01 +0200 Original-Received: (qmail 12563 invoked by uid 1001); 4 Apr 2005 10:58:42 -0000 Mailing-List: contact semi-gnus-ja-help@meadowy.org; run by ezmlm Original-Sender: semi-gnus-ja-owner@meadowy.org X-ML-NAME: semi-gnus-ja Precedence: bulk Original-Received: (qmail 2763 invoked from network); 4 Apr 2005 10:58:41 -0000 X-SendingHost: 194.109.24.28 Original-To: Reiner Steib In-Reply-To: (Reiner Steib's message of "Mon, 04 Apr 2005 12:25:19 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Original-Lines: 19 X-Virus-Scanned: by XS4ALL Virus Scanner X-ML-COUNT: 12946 Xref: news.gmane.org gmane.emacs.gnus.semi.japanese:5669 gmane.emacs.devel:35534 gmane.emacs.gnus.general:60086 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35534 Reiner Steib writes: >> I removed (require 'parse-time) from time-date because it uses just >> parse-time-string, which is autoloaded. Do I understand correctly my >> change uncovered some bugs in nnimap.el, nnultimate.el and pop3.el? I >> already noticed (and fixed) this for message.el. > > Wouldn't it be better to put (require 'parse-time) at the beginning of > the file instead of inside `message-make-date'? message-make-date is the only function in message.el that uses parse-time, so it's best to put the require there. If you change message-make-date so that it no longer uses parse-time, you will probably notice the require and remove it. Had you put require at the beginning of the file, you would most likely forget this. Putting a require at the beginning of a file is useful if the file uses a particular feature a lot. Lute.