From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Diff mode faces Date: Mon, 11 Jul 2005 03:06:40 +0300 Organization: JURTA Message-ID: <87mzoudrff.fsf@jurta.org> References: <87oea5urwm.fsf@jurta.org> <87psujj0h0.fsf@jurta.org> <86hdfv1y9b.fsf@blue.stonehenge.com> <87r7eyqzcy.fsf@jurta.org> <200506191710.j5JHAEN11479@raven.dms.auburn.edu> <877jgfi40l.fsf@jurta.org> <874qb7k65j.fsf@jurta.org> <87fyunwph1.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1121054530 13431 80.91.229.2 (11 Jul 2005 04:02:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 11 Jul 2005 04:02:10 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 11 06:02:07 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DrpUT-0000N7-8h for ged-emacs-devel@m.gmane.org; Mon, 11 Jul 2005 06:01:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DrpUA-0006hs-VI for ged-emacs-devel@m.gmane.org; Mon, 11 Jul 2005 00:01:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DrpTp-0006fF-LJ for emacs-devel@gnu.org; Mon, 11 Jul 2005 00:01:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DrpTa-0006V7-Gq for emacs-devel@gnu.org; Mon, 11 Jul 2005 00:01:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DrpTU-0006Py-3x for emacs-devel@gnu.org; Mon, 11 Jul 2005 00:00:56 -0400 Original-Received: from [194.126.101.116] (helo=HOT-Bounce1.hot.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DrpJa-0002M0-66; Sun, 10 Jul 2005 23:50:42 -0400 Original-Received: from mail.neti.ee (Relay5 [192.168.1.24]) by HOT-Bounce1.hot.ee (Postfix) with ESMTP id B33F9158DD7; Mon, 11 Jul 2005 06:29:19 +0300 (EEST) Original-Received: from mail.neti.ee (80-235-32-152-dsl.mus.estpak.ee [80.235.32.152]) by Relayhost1.neti.ee (Postfix) with ESMTP id 27E4C16B0; Mon, 11 Jul 2005 06:42:41 +0300 (EEST) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Sun, 10 Jul 2005 06:34:06 +0300") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40744 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40744 > This part affects non-TTY platforms, while leaving the TTY colors > intact. Why? I don't think there's any problem with Diff-mode colors > on displays that support many colors, are there? Maybe the following patch is more correct: Index: lisp/diff-mode.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/diff-mode.el,v retrieving revision 1.78 diff -u -r1.78 diff-mode.el --- lisp/diff-mode.el 4 Jul 2005 23:08:52 -0000 1.78 +++ lisp/diff-mode.el 11 Jul 2005 00:06:51 -0000 @@ -197,7 +197,7 @@ (((class color) (min-colors 88) (background dark)) :background "grey60" :weight bold) (((class color) (background light)) - :foreground "yellow" :weight bold) + :foreground "green" :weight bold) (((class color) (background dark)) :foreground "cyan" :weight bold) (t :weight bold)) ; :height 1.3 @@ -259,7 +280,7 @@ (defvar diff-function-face 'diff-function) (defface diff-context - '((t :inherit shadow)) + '((((class color) (min-colors 88)) :inherit shadow)) "`diff-mode' face used to highlight context and other side-information." :group 'diff-mode) ;; backward-compatibility alias -- Juri Linkov http://www.jurta.org/emacs/