From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: C-f in isearch minibuffer (was: should search ring contain duplicates?) Date: Thu, 11 May 2006 14:59:03 +0300 Organization: JURTA Message-ID: <87mzdokank.fsf_-_@jurta.org> References: <200605030727.k437R2Wx009975@amrm2.ics.uci.edu> <87bqufwbls.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1147352461 15914 80.91.229.2 (11 May 2006 13:01:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 May 2006 13:01:01 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 11 15:01:00 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FeAmp-0002jR-VF for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 15:01:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FeAmp-0003yR-Dy for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 09:00:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FeAlS-0002yV-E9 for emacs-devel@gnu.org; Thu, 11 May 2006 08:59:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FeAlP-0002tq-AI for emacs-devel@gnu.org; Thu, 11 May 2006 08:59:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FeAlP-0002ta-5q for emacs-devel@gnu.org; Thu, 11 May 2006 08:59:31 -0400 Original-Received: from [217.25.160.1] (helo=relay1.binet.com.ua) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FeAmu-00075f-Op for emacs-devel@gnu.org; Thu, 11 May 2006 09:01:05 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by relay1.binet.com.ua (Postfix) with ESMTP id AF67A77DA6 for ; Thu, 11 May 2006 15:59:29 +0300 (EEST) Original-Received: from mail.binet.com.ua (i45.dialup.binet.com.ua [217.25.161.109]) by relay1.binet.com.ua (Postfix) with ESMTP id 0F5AA77D83 for ; Thu, 11 May 2006 15:59:27 +0300 (EEST) Original-To: emacs-devel@gnu.org In-Reply-To: <87bqufwbls.fsf@jurta.org> (Juri Linkov's message of "Wed, 03 May 2006 15:48:48 +0300") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by ClamAv at binet.com.ua X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54260 Archived-At: > I think this is a good idea. This would help to get rid of a new > useless argument `keep-all' added a few months ago to the function > `read-from-minibuffer' only for the sake of query-replace. > Since query-replace is the only place in Emacs that uses this new argument, > it is better to remove it now before the release, and to use a new > macro `history-push' in `query-replace-read-to' to treat the query-replace > history specially. This reminds me of another misfeature. C-f typed at the end of the isearch's minibuffer that pulls characters from the parent buffer is not user-friendly. With recently proposed special commands like `M-.' in the minibuffer to pull things from the parent buffer to be implemented in the next release, I think it is better to get rid of this misfeature before this release: Index: lisp/isearch.el =================================================================== RCS file: /sources/emacs/emacs/lisp/isearch.el,v retrieving revision 1.288 diff -c -r1.288 isearch.el *** lisp/isearch.el 5 May 2006 23:37:31 -0000 1.288 --- lisp/isearch.el 11 May 2006 11:55:45 -0000 *************** *** 418,425 **** (define-key map "\M-\t" 'isearch-complete-edit) (define-key map "\C-s" 'isearch-forward-exit-minibuffer) (define-key map "\C-r" 'isearch-reverse-exit-minibuffer) - (define-key map "\C-f" 'isearch-yank-char-in-minibuffer) - (define-key map [right] 'isearch-yank-char-in-minibuffer) map) "Keymap for editing isearch strings in the minibuffer.") --- 418,423 ---- *************** *** 1322,1338 **** (goto-char isearch-other-end)) (buffer-substring-no-properties (point) (funcall jumpform))))) - (defun isearch-yank-char-in-minibuffer (&optional arg) - "Pull next character from buffer into end of search string in minibuffer." - (interactive "p") - (if (eobp) - (insert - (save-excursion - (set-buffer (cadr (buffer-list))) - (buffer-substring-no-properties - (point) (progn (forward-char arg) (point))))) - (forward-char arg))) - (defun isearch-yank-char (&optional arg) "Pull next character from buffer into search string." (interactive "p") --- 1341,1346 ---- -- Juri Linkov http://www.jurta.org/emacs/