From: Ryan Yeske <rcyeske@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: rcirc bug
Date: Tue, 05 Sep 2006 14:27:45 -0700 [thread overview]
Message-ID: <87mz9eknqm.fsf@cut.bc.hsia.telus.net> (raw)
In-Reply-To: <20060904135111.7ADB544005@Psilocybe.Update.UU.SE> (Alfred M. Szmidt's message of "Mon\, 4 Sep 2006 15\:51\:11 +0200 \(CEST\)")
"Alfred M. Szmidt" <ams@gnu.org> writes:
> Hey,
>
> rcirc tries to use member* without (require 'cl), which causes
> breakage.
The following patch fixes this:
*** rcirc.el 05 Sep 2006 12:14:49 -0700 1.26
--- rcirc.el 05 Sep 2006 14:22:05 -0700
***************
*** 1544,1552 ****
(with-current-buffer b
(dolist (type rcirc-activity-types)
(rcirc-add-face 0 (length s)
! (case type
! ('nick 'rcirc-track-nick)
! ('keyword 'rcirc-track-keyword))
s)))
s))
buffers ","))
--- 1544,1552 ----
(with-current-buffer b
(dolist (type rcirc-activity-types)
(rcirc-add-face 0 (length s)
! (cond
! ((eq type 'nick) 'rcirc-track-nick)
! ((eq type 'keyword) 'rcirc-track-keyword))
s)))
s))
buffers ","))
***************
*** 1936,1945 ****
(defun rcirc-markup-attributes (process sender response channel-buffer)
(while (re-search-forward "\\([\C-b\C-_\C-v]\\).*?\\(\\1\\|\C-o\\)" nil t)
(rcirc-add-face (match-beginning 0) (match-end 0)
! (case (char-after (match-beginning 1))
! (?\C-b 'bold)
! (?\C-v 'italic)
! (?\C-_ 'underline)))
;; keep the ^O since it could terminate other attributes
(when (not (eq ?\C-o (char-before (match-end 2))))
(delete-region (match-beginning 2) (match-end 2)))
--- 1936,1945 ----
(defun rcirc-markup-attributes (process sender response channel-buffer)
(while (re-search-forward "\\([\C-b\C-_\C-v]\\).*?\\(\\1\\|\C-o\\)" nil t)
(rcirc-add-face (match-beginning 0) (match-end 0)
! (let ((ch (char-after (match-beginning 1))))
! (cond ((eq ch ?\C-b) 'bold)
! ((eq ch ?\C-v) 'italic)
! ((eq ch ?\C-_) 'underline))))
;; keep the ^O since it could terminate other attributes
(when (not (eq ?\C-o (char-before (match-end 2))))
(delete-region (match-beginning 2) (match-end 2)))
next prev parent reply other threads:[~2006-09-05 21:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 13:51 rcirc bug Alfred M. Szmidt
2006-09-05 9:42 ` Richard Stallman
2006-09-05 21:27 ` Ryan Yeske [this message]
2006-09-05 21:37 ` Alfred M. Szmidt
2006-09-05 21:44 ` Ryan Yeske
2006-09-06 19:06 ` Richard Stallman
2006-09-06 19:13 ` Ryan Yeske
2006-09-07 23:19 ` Ryan Yeske
2006-09-08 15:11 ` Richard Stallman
2006-09-08 15:30 ` Drew Adams
2006-09-11 2:57 ` Chong Yidong
2006-09-11 15:17 ` Stuart D. Herring
2006-09-11 19:57 ` Richard Stallman
2006-09-05 21:44 ` Magnus Henoch
2006-09-07 20:59 ` Chong Yidong
2006-09-07 21:11 ` Stefan Monnier
2006-09-05 21:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mz9eknqm.fsf@cut.bc.hsia.telus.net \
--to=rcyeske@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).