From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Bogus byte-compiler warnings Date: Sun, 19 Nov 2006 10:18:32 -0500 Message-ID: <87mz6nfos7.fsf@furball.mit.edu> References: <87zmar47tm.fsf@cyd.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1163949620 9910 80.91.229.2 (19 Nov 2006 15:20:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2006 15:20:20 +0000 (UTC) Cc: Reiner.Steib@gmx.de, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 19 16:20:18 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GloSe-0005A5-CC for ged-emacs-devel@m.gmane.org; Sun, 19 Nov 2006 16:20:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GloSd-0007xr-ML for ged-emacs-devel@m.gmane.org; Sun, 19 Nov 2006 10:19:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GloRT-0007SI-F7 for emacs-devel@gnu.org; Sun, 19 Nov 2006 10:18:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GloRS-0007Rq-Sx for emacs-devel@gnu.org; Sun, 19 Nov 2006 10:18:46 -0500 Original-Received: from [18.72.1.2] (helo=south-station-annex.mit.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GloRS-0007by-N5; Sun, 19 Nov 2006 10:18:46 -0500 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id kAJFIfCk019069; Sun, 19 Nov 2006 10:18:42 -0500 (EST) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id kAJFIbu1010823; Sun, 19 Nov 2006 10:18:38 -0500 (EST) Original-Received: from furball.mit.edu (SYDNEYPACIFIC-FOUR-FORTY-FOUR.MIT.EDU [18.95.6.189]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id kAJFIXGY027402; Sun, 19 Nov 2006 10:18:33 -0500 (EST) Original-Received: from cyd by furball.mit.edu with local (Exim 3.36 #1 (Debian)) id 1GloRE-0000cC-00; Sun, 19 Nov 2006 10:18:32 -0500 Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sun\, 19 Nov 2006 02\:59\:43 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62473 Archived-At: Richard Stallman writes: > > The reason there is a warning for foo-1 is that the code in the > > compiler to avoid such warnings recognizes only the simpler case (such > > as foo-2) and not the more complex case that foo-1 is. > > > > I would not mind if that code were made smarter. > > How bout this patch? > > I think it would be better to save this for after the release. > Changes in this code are somewhat risky, and even if you have > been rather careful, you could easily break something. I had already checked it into CVS (since you put it in FOR-RELEASE, I assumed you wanted it fixed). But I agree that now is not the time for such changes, so I've reverted the change.