quoted buffer object

quoted buffer object

[Thien-Thi Nguyen]

in vc.el:999, i see:

  (with-current-buffer ',(current-buffer)

weird.  here are some experiments in *scratch*:

  (bufferp (current-buffer))
  t
  
  (bufferp (car `(,(current-buffer))))
  t
  
  (bufferp (car `(',(current-buffer))))
  nil

i conclude the code as it stands does not DTRT.
perhaps it should be changed to:

  (with-current-buffer ,(buffer-name (current-buffer))

?  any objections?

thi

Re: quoted buffer object

[Johan Bockgård]

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> in vc.el:999, i see:
>
>   (with-current-buffer ',(current-buffer)
>
> weird.  here are some experiments in *scratch*:
>
>   (bufferp (current-buffer))
>   t
>   
>   (bufferp (car `(,(current-buffer))))
>   t
>   
>   (bufferp (car `(',(current-buffer))))
>   nil
>
> i conclude the code as it stands does not DTRT.

But 'x *evaluates* to x, so the quote is harmless (though superfluous,
since buffer objects are self-evaluating).

  `(lambda ()
     (with-current-buffer ',(current-buffer) ...))

     =>  (lambda nil (with-current-buffer '#<buffer foo> ...))

which will DTRT.

-- 
Johan Bockgård

Re: quoted buffer object

[Stefan Monnier]

> But 'x *evaluates* to x, so the quote is harmless (though superfluous,
> since buffer objects are self-evaluating).

Indeed, the quote can be optimized away, but I don't think it hurts either:
better safe than sorry.


        Stefan