remember-region should be autoloaded

remember-region should be autoloaded

[Ryan Yeske]

I usually use M-x remember-region to record notes from text in my emacs
buffers.


2007-12-19  Ryan Yeske  <rcyeske@gmail.com>

	* textmodes/remember.el (remember-region): Add autoload cookie.


diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
index 81be7ac..01d1954 100644
--- a/lisp/textmodes/remember.el
+++ b/lisp/textmodes/remember.el
@@ -419,6 +419,7 @@ Subject: %s\n\n"
               (when remember-save-after-remembering (save-buffer))))
         (append-to-file (point-min) (point-max) remember-data-file)))))
 
+;;;###autoload
 (defun remember-region (&optional beg end)
   "Remember the data from BEG to END.
 It is called from within the *Remember* buffer to save the text


Diffs between working revision and workfile end here.

Re: remember-region should be autoloaded

[Lennart Borgman (gmail)]

Ryan Yeske wrote:
> I usually use M-x remember-region to record notes from text in my emacs
> buffers.
> 
> 
> 2007-12-19  Ryan Yeske  <rcyeske@gmail.com>
> 
> 	* textmodes/remember.el (remember-region): Add autoload cookie.
> 
> 
> diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
> index 81be7ac..01d1954 100644
> --- a/lisp/textmodes/remember.el
> +++ b/lisp/textmodes/remember.el
> @@ -419,6 +419,7 @@ Subject: %s\n\n"
>                (when remember-save-after-remembering (save-buffer))))
>          (append-to-file (point-min) (point-max) remember-data-file)))))
>  
> +;;;###autoload
>  (defun remember-region (&optional beg end)
>    "Remember the data from BEG to END.
>  It is called from within the *Remember* buffer to save the text
> 
> 
> Diffs between working revision and workfile end here.

In my version of remember.el remember-region is already autoloaded, but 
it looks to me from the doc string like it should not be that since it 
is meant to be called from the *Remember* buffer.

However there is a small bug in remember in the way it handles the 
region. Beside that it would be nice if it used the region when it is 
visible. Something like this in the beginning of remember:

(defun remember (&optional initial)
   "Remember an arbitrary piece of data.
With a prefix or a visible region, uses the region as INITIAL."
   (interactive
    (list (when (or current-prefix-arg
                    (and mark-active
                         transient-mark-mode))
            (buffer-substring-noproperties
             (region-beginning) (region-end)))))

Re: remember-region should be autoloaded

[Leo]

On 2007-12-19 11:15 +0000, Lennart Borgman (gmail) wrote:
> However there is a small bug in remember in the way it handles the
> region. Beside that it would be nice if it used the region when it
> is visible. Something like this in the beginning of remember:

This feature has been demanded for more than a year and there is even a
patch on its mailing list.

-- 
.:  Leo  :.  [ sdl.web AT gmail.com ]  .:  [ GPG Key: 9283AA3F ]  :.

          Use the best OS -- http://www.fedoraproject.org/

Re: remember-region should be autoloaded

[Michael Olson]

[-- Attachment #1.1: Type: text/plain, Size: 740 bytes --]

Leo <sdl.web@gmail.com> writes:

> On 2007-12-19 11:15 +0000, Lennart Borgman (gmail) wrote:
>> However there is a small bug in remember in the way it handles the
>> region. Beside that it would be nice if it used the region when it
>> is visible. Something like this in the beginning of remember:
>
> This feature has been demanded for more than a year and there is even
> a patch on its mailing list.

I've now made the changes suggested in Lennart's email message.

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
          Programmer -- Hobbies: Lisp, HCoop          | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: remember-region should be autoloaded

[Juri Linkov]

> However there is a small bug in remember in the way it handles the
> region. Beside that it would be nice if it used the region when it is
> visible. Something like this in the beginning of remember:
>
> (defun remember (&optional initial)
>   "Remember an arbitrary piece of data.
> With a prefix or a visible region, uses the region as INITIAL."
>   (interactive
>    (list (when (or current-prefix-arg
>                    (and mark-active
>                         transient-mark-mode))
>            (buffer-substring-noproperties
>             (region-beginning) (region-end)))))

This is nice, but what was the conclusion about adding a special function
to check the active region with just one function call?

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: remember-region should be autoloaded

[Lennart Borgman (gmail)]

Juri Linkov wrote:
>> However there is a small bug in remember in the way it handles the
>> region. Beside that it would be nice if it used the region when it is
>> visible. Something like this in the beginning of remember:
>>
>> (defun remember (&optional initial)
>>   "Remember an arbitrary piece of data.
>> With a prefix or a visible region, uses the region as INITIAL."
>>   (interactive
>>    (list (when (or current-prefix-arg
>>                    (and mark-active
>>                         transient-mark-mode))
>>            (buffer-substring-noproperties
>>             (region-beginning) (region-end)))))
> 
> This is nice, but what was the conclusion about adding a special function
> to check the active region with just one function call?

I do not remember the name of that function.

Re: remember-region should be autoloaded

[Richard Stallman]

    This is nice, but what was the conclusion about adding a special function
    to check the active region with just one function call?

I wrote that a few weeks ago but had not installed it.
I installed it just now.  It is called `region-active-p'
and it is in simple.el.

It would be good to change the commands that now check for an active region
to use `region-active-p'.