From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Phil Hagelberg Newsgroups: gmane.emacs.devel Subject: Re: CEDET merge Date: Tue, 06 Oct 2009 20:43:37 -0700 Message-ID: <87my43yil2.fsf@hagelb.org> References: <87hbun9jbs.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1254887047 30582 80.91.229.12 (7 Oct 2009 03:44:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Oct 2009 03:44:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 07 05:43:57 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MvNRT-0004jY-Jc for ged-emacs-devel@m.gmane.org; Wed, 07 Oct 2009 05:43:55 +0200 Original-Received: from localhost ([127.0.0.1]:58427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvNRS-00018I-Tm for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2009 23:43:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvNRM-000181-CC for emacs-devel@gnu.org; Tue, 06 Oct 2009 23:43:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvNRG-00017F-UE for emacs-devel@gnu.org; Tue, 06 Oct 2009 23:43:47 -0400 Original-Received: from [199.232.76.173] (port=33899 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvNRG-00017C-RI for emacs-devel@gnu.org; Tue, 06 Oct 2009 23:43:42 -0400 Original-Received: from caiajhbdcagg.dreamhost.com ([208.97.132.66]:41184 helo=homiemail-a13.g.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvNRG-0006pY-GC for emacs-devel@gnu.org; Tue, 06 Oct 2009 23:43:42 -0400 Original-Received: from enigma (dsl231-038-147.sea1.dsl.speakeasy.net [216.231.38.147]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by homiemail-a13.g.dreamhost.com (Postfix) with ESMTPSA id 2E1836A8073; Tue, 6 Oct 2009 20:43:39 -0700 (PDT) In-Reply-To: <87hbun9jbs.fsf@stupidchicken.com> (Chong Yidong's message of "Mon, 28 Sep 2009 11:31:51 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115946 Archived-At: Chong Yidong writes: > I have merged most of the CEDET branch into the trunk. You may need to > bootstrap; please let me know if there are any build failures. > > I have done what I can to clean up CEDET to conform to Emacs standards; > if you see anything I missed, please go ahead and make the change. The doc header at the top of pulse.el mentions the function pulse-enable-integration-advice, which has been removed presumably to conform to Emacs "no advice in core" standard. But the comment has not been updated. The patch below fixes this. -Phil diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el index c7ece45..7977104 100644 --- a/lisp/cedet/pulse.el +++ b/lisp/cedet/pulse.el @@ -27,11 +27,6 @@ ;; highlighted briefly. This adds a gentle pulsing style to the text ;; decorated this way. ;; -;; Useful user functions: -;; -;; `pulse-enable-integration-advice' - Turn on advice to make various -;; Emacs commands pulse, such as `goto-line', or `find-tag'. -;; ;; The following are useful entry points: ;; ;; `pulse' - Cause `pulse-highlight-face' to shift toward background color.