From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el bug report Date: Mon, 28 Dec 2009 08:41:56 +0100 Organization: ThierryVolpiatto Message-ID: <87my13lf3v.fsf@tux.homenetwork> References: <5065e2900912272219y3734fc9fsdaee41167ef99ad7@mail.gmail.com> <87aax361bd.fsf@red-bean.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1261986488 5559 80.91.229.12 (28 Dec 2009 07:48:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2009 07:48:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 08:48:01 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NPAKe-0003uN-Ou for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2009 08:48:01 +0100 Original-Received: from localhost ([127.0.0.1]:40222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NPAKe-0005Lu-Gu for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2009 02:48:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NPAKS-0005Lh-6M for emacs-devel@gnu.org; Mon, 28 Dec 2009 02:47:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NPAKL-0005JY-BV for emacs-devel@gnu.org; Mon, 28 Dec 2009 02:47:46 -0500 Original-Received: from [199.232.76.173] (port=57413 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NPAKL-0005JV-5s for emacs-devel@gnu.org; Mon, 28 Dec 2009 02:47:41 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:48405) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NPAKK-00067C-Lw for emacs-devel@gnu.org; Mon, 28 Dec 2009 02:47:40 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1NPAKG-0003on-HT for emacs-devel@gnu.org; Mon, 28 Dec 2009 08:47:36 +0100 Original-Received: from 85.77.197-77.rev.gaoland.net ([77.197.77.85]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 Dec 2009 08:47:36 +0100 Original-Received: from thierry.volpiatto by 85.77.197-77.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 Dec 2009 08:47:36 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 85.77.197-77.rev.gaoland.net Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHBARgJRFPS0WbMBTC TSG/uJs0yyVHAAAACXBIWXMAAAsSAAALEgHS3X78AAAACXZwQWcAAAAwAAAAMADO7oxXAAABpUlE QVQ4y3VTQXKDMAyUnD7AwvQOhtxj5N4LFh9ow/+/UtlpM0BczWSS0Wola7UBeEb3+3kJ/5p9ZLz3 UI0n0J0Y4K/lh1nG24FhlJOR2LdSKtpV5gfi/Zd+NdaJBbB4D5N0JnfUIVp6obZURkJwS2a8b9uX AkgxA5gCEcknAH1s2z0DPooWmjGKcJR+HNZt+9bm0GtGRycRuZGs98Ffr02vABWGopIAhmXmxnQN BwBXZjgFLHRoqbfeYxCLWqsjLyKhbEHW+A5nEs699Q2O80ALrgHTmUTy6P0MnKyKQpKHpoNWokxs F0D5VegvWmEozyE6nuMiS98mWzlUQ9bW8qYfqOaFtzWlYCqGeIs6HEyl08jkrxUG9MF5ipXpOOpd ZMoXPPVSLWJiiwNNB+eRSyxJZmQKcacikgucnCRiHuJOLmyYJRDPwOqAvY4pA+Wy+VS8G26BAsdb Ph2Hw7ORy/H0IOG0TnaM8Cp0XrFYyU0v2z8AqkifPVbLZ0qo/gsRg60C7p+8Ov9jrUIxFde+jnAq X42hyp/c+ZcnVyUYBarrqZt3+R8450png3cWKgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAwOC0wNS0z MVQyMjoxNDoyMiswMjowMK3VBDcAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMDctMTAtMjhUMTc6MDg6 NDgrMDE6MDDLdIcLAAAAEXRFWHRqcGVnOmNvbG9yc3BhY2UAMix1VZ8AAAAgdEVYdGpwZWc6c2Ft cGxpbmctZmFjdG9yADJ4MiwxeDEsMXgxSfqmtAAAAABJRU5ErkJggg== User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.90 (gnu/linux) Cancel-Lock: sha1:0liJ/BjeC94DIMPLsi9yObHnzhY= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118850 Archived-At: Karl Fogel writes: > Sun Yijiang writes: >> `bookmark-bmenu-execute-deletions' is broken for quite some time. I >> think I've found the problem. When it calls >> `bookmark-bmenu-bookmark', the callee gets text property at >> `(line-begging-position)', which is incorrect in this context. Below >> is the patched code of `bookmark-bmenu-bookmark' that works for me: >> >> (defun bookmark-bmenu-bookmark () >> "Return the bookmark for this line in an interactive bookmark list buffer." >> (when (bookmark-bmenu-check-position) >> (let ((pos (line-beginning-position))) >> (when (looking-back "^[^ ]") >> (setq pos (+ 1 pos))) >> (get-text-property pos 'bookmark-name-prop)))) > > Thank you -- I will take a look! Consider using the definition of bookmark-extensions.el: (That's what i sent in original patch for bookmark.el) (defun bookmark-bmenu-bookmark () "Return the name of the bookmark on this line." (when (bookmark-bmenu-check-position) (save-excursion (forward-line 0) (forward-char 3) (get-text-property (point) 'bmkext-bookmark-name)))) -- A + Thierry Volpiatto Location: Saint-Cyr-Sur-Mer - France