From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: bug: epg send unencrypted data in trash Date: Fri, 11 Feb 2011 19:23:06 -0500 Message-ID: <87mxm285jp.fsf@stupidchicken.com> References: <87oc6jav1s.fsf@gmail.com> <87k4h6sahe.fsf@gmail.com> <87sjvuxs80.fsf@lifelogs.com> <87aai2s2nu.fsf@gmail.com> <87oc6iw75t.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297470202 14304 80.91.229.12 (12 Feb 2011 00:23:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Feb 2011 00:23:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 12 01:23:17 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Po3Gf-0003H5-C8 for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 01:23:17 +0100 Original-Received: from localhost ([127.0.0.1]:43055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Po3Ge-0005M4-Ta for ged-emacs-devel@m.gmane.org; Fri, 11 Feb 2011 19:23:16 -0500 Original-Received: from [140.186.70.92] (port=52558 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Po3Ga-0005Ll-A6 for emacs-devel@gnu.org; Fri, 11 Feb 2011 19:23:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Po3GY-0004fS-H6 for emacs-devel@gnu.org; Fri, 11 Feb 2011 19:23:12 -0500 Original-Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]:60444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Po3GY-0004fL-1q for emacs-devel@gnu.org; Fri, 11 Feb 2011 19:23:10 -0500 Original-Received: from furball (dhcp128036014062.central.yale.edu [128.36.14.62]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1C0N7B1006959 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 11 Feb 2011 19:23:08 -0500 Original-Received: by furball (Postfix, from userid 1000) id EFFEF16055E; Fri, 11 Feb 2011 19:23:06 -0500 (EST) In-Reply-To: <87oc6iw75t.fsf@lifelogs.com> (Ted Zlatanov's message of "Fri, 11 Feb 2011 16:14:22 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.144 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135922 Archived-At: Ted Zlatanov writes: > On Fri, 11 Feb 2011 22:05:09 +0100 Thierry Volpiatto > wrote: > > TV> Ted Zlatanov writes: >>> According to the docs for `delete-file' it shouldn't matter what >>> `delete-by-moving-to-trash' says because this is called >>> non-interactively (TRASH is nil when delete-file is called >>> non-interactively). Or is this funcall interactive somehow? > TV> I don't know, but actually without delete-by-moving-to-trash let-bound > TV> to nil, non--encrypted data goes to trash. > > I think this is because in the C source (fileio.c) TRASH is set to > "(null current-prefix-arg)" which is not equivalent to > `called-interactively-p' AFAIK. IOW I think your fix is masking the > underlying problem. But I don't know the C source so well so I could be > misunderstanding things. Perhaps Chong Yidong, who created revision > 100462 and introduced the TRASH parameter, can check it. I think TV is using the emacs-23 branch, where the TRASH parameter is not present. I've changed EPA and EPG to bind delete-by-moving-to-trash to nil there. No fix is necessary for the trunk, IIUC.