Re: bug: epg send unencrypted data in trash

[Chong Yidong <cyd@stupidchicken.com>]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Fri, 11 Feb 2011 22:05:09 +0100 Thierry Volpiatto
> <thierry.volpiatto@gmail.com> wrote:
>
> TV> Ted Zlatanov <tzz@lifelogs.com> writes:
>>> According to the docs for `delete-file' it shouldn't matter what
>>> `delete-by-moving-to-trash' says because this is called
>>> non-interactively (TRASH is nil when delete-file is called
>>> non-interactively).  Or is this funcall interactive somehow?
> TV> I don't know, but actually without delete-by-moving-to-trash let-bound
> TV> to nil, non--encrypted data goes to trash.
>
> I think this is because in the C source (fileio.c) TRASH is set to
> "(null current-prefix-arg)" which is not equivalent to
> `called-interactively-p' AFAIK.  IOW I think your fix is masking the
> underlying problem.  But I don't know the C source so well so I could be
> misunderstanding things.  Perhaps Chong Yidong, who created revision
> 100462 and introduced the TRASH parameter, can check it.

I think TV is using the emacs-23 branch, where the TRASH parameter is
not present.  I've changed EPA and EPG to bind delete-by-moving-to-trash
to nil there.  No fix is necessary for the trunk, IIUC.