From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: post-command-hook Date: Sun, 03 Apr 2011 00:38:15 +0200 Message-ID: <87mxk8mg88.fsf@gnu.org> References: <4D95F608.8020501@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301783936 5511 80.91.229.12 (2 Apr 2011 22:38:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2011 22:38:56 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 03 00:38:52 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q69Sz-0005hp-TP for ged-emacs-devel@m.gmane.org; Sun, 03 Apr 2011 00:38:50 +0200 Original-Received: from localhost ([127.0.0.1]:48843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q69Sy-0005Gd-FJ for ged-emacs-devel@m.gmane.org; Sat, 02 Apr 2011 18:38:48 -0400 Original-Received: from [140.186.70.92] (port=39268 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q69So-00054R-Jm for emacs-devel@gnu.org; Sat, 02 Apr 2011 18:38:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q69Sj-00079m-KB for emacs-devel@gnu.org; Sat, 02 Apr 2011 18:38:38 -0400 Original-Received: from smtprelay-b21.telenor.se ([195.54.99.212]:41176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q69Sj-00079X-Ez for emacs-devel@gnu.org; Sat, 02 Apr 2011 18:38:33 -0400 Original-Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-b21.telenor.se (Postfix) with ESMTP id 2CC66C1E5 for ; Sun, 3 Apr 2011 00:38:30 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.229.2.199] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtFnADukl01V5QLHPGdsb2JhbACJEY9TjH0LAQEBATcyiHm1LYVrBA X-IronPort-AV: E=Sophos;i="4.63,290,1299452400"; d="scan'208";a="1719668778" Original-Received: from c-c702e555.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.229.2.199]) by ipb4.telenor.se with ESMTP; 03 Apr 2011 00:38:17 +0200 Original-Received: by muon.localdomain (Postfix, from userid 1000) id E385A484F7F; Sun, 3 Apr 2011 00:38:15 +0200 (CEST) Mail-Copies-To: never In-Reply-To: (Stefan Monnier's message of "Sat, 02 Apr 2011 17:40:17 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 195.54.99.212 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138078 Archived-At: Stefan Monnier writes: >> (defun foo () >> (message "foo")) >> (defun bar () >> (message "bar")) >> (add-hook 'post-command-hook 'foo) >> (add-hook 'post-command-hook 'bar nil t) > > I think the patch below fixes it, > > safe_run_hooks_1 (void) > { > eassert (CONSP (Vinhibit_quit)); > - return call0 (XCDR (Vinhibit_quit)); > + call0 (XCDR (Vinhibit_quit)); > + return Qnil; > } Shouldn't the "return nil" be in safe_run_hook_funcall instead?