unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: pop-to-buffer and friends new behavior or bug?
Date: Tue, 21 Jun 2011 17:11:33 +0200	[thread overview]
Message-ID: <87mxhb1aoq.fsf@gmail.com> (raw)
In-Reply-To: <4E00ADAA.4040206@gmx.at> (martin rudalics's message of "Tue, 21 Jun 2011 16:41:46 +0200")

martin rudalics <rudalics@gmx.at> writes:

>> I have fixed my problem in anything.el using this:
>>
>> --8<---------------cut here---------------start------------->8---
>> [...]
>>     (when (boundp 'display-buffer-alist)
>>       (setq not-this-window '((reuse-window same other nil)
>>                               (pop-up-window (other)))))
>>     (display-buffer buf not-this-window)))
>> --8<---------------cut here---------------end--------------->8---
>>
>> It is working fine like this, but i would like to know if that is
>> correct.
>
> I suppose it's reusing another window now because the reuse-window
> specifier is correct - try the selected window if it shows another
> buffer.  The pop-up-window specifier wants a list of window . side
> conses like (pop-up-window (largest . below) (selected .right)) to split
> the largest window with the new window below or the selected window with
> the new window on the right.
Ok, so the (pop-up-window (other)) is incorrect (or incomplete) and
maybe unuseful in this case.

> But please don't fix this before I found the cause of the bug.  Having a
> sample where it tries to use the minibuffer window is important for me.
> (Unfortunately, I haven't git installed so I first have to get this from
> somewhere else.  Or you send me the files exposing the bug via private
> mail?)
No problem if you have not git, just download the tarball here:
http://repo.or.cz/w/anything-config.git

Last revision have bug fixed with the code above, just comment it out,
or download the revision just before to have the bug:

--8<---------------cut here---------------start------------->8---
author	Thierry Volpiatto <thierry.volpiatto@gmail.com>	
Mon, 20 Jun 2011 20:28:20 +0000 (22:28 +0200)
committer	Thierry Volpiatto <thierry.volpiatto@gmail.com>	
Mon, 20 Jun 2011 20:28:20 +0000 (22:28 +0200)
commit	fe786b9d1cbcb8431468f309ed7fa5f5676d47b0
tree	21694f5a4f95654dac54d7e580dab1ca4b40fcd4
parent	9e7236e34f98ba1a5ad8b6414f7f45df70bc531e
--8<---------------cut here---------------end--------------->8---

The relevant code is in anything.el starting at line 3123 at:
;; (@* "Utility: Persistent Action")

and more exactly in `anything-persistent-action-display-buffer'.

Follow the recipe i sent in precedent mail.
To see what is expected use the fixed code.

You will find a pdf file in the ../doc directory, even if it's not
up to date, it can help you if you are not familiar with anything.

Thanks.

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 



  reply	other threads:[~2011-06-21 15:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16 18:02 pop-to-buffer and friends new behavior or bug? Thierry Volpiatto
2011-06-16 20:16 ` Thierry Volpiatto
2011-06-16 20:35   ` martin rudalics
2011-06-16 22:00     ` Thierry Volpiatto
2011-06-17 15:46       ` martin rudalics
2011-06-17 16:01     ` Thierry Volpiatto
2011-06-18 16:10       ` martin rudalics
2011-06-18 17:19         ` Thierry Volpiatto
2011-06-18 19:53         ` Thierry Volpiatto
2011-06-19 13:26           ` martin rudalics
2011-06-19 18:49             ` Thierry Volpiatto
2011-06-20  8:29             ` Thierry Volpiatto
2011-06-20  9:24               ` martin rudalics
2011-06-20  9:59                 ` Thierry Volpiatto
2011-06-21 13:25                 ` Thierry Volpiatto
2011-06-21 14:41                   ` martin rudalics
2011-06-21 15:11                     ` Thierry Volpiatto [this message]
2011-06-21 16:12                       ` martin rudalics
2011-06-21 17:23                         ` Thierry Volpiatto
2011-06-22 16:00                           ` martin rudalics
2011-06-22 16:23                             ` Thierry Volpiatto
2011-06-23  9:49                               ` martin rudalics
2011-06-23 10:15                                 ` Thierry Volpiatto
2011-06-23 11:07                                   ` martin rudalics
2011-06-23 15:56                                     ` Thierry Volpiatto
2011-06-23 16:07                                       ` martin rudalics
2011-06-23 17:22                                         ` Thierry Volpiatto
2011-06-23 18:51                                         ` Thierry Volpiatto
2011-06-24  7:01                                           ` martin rudalics
2011-06-24  7:10                                             ` Thierry Volpiatto
2011-06-16 21:10 ` David Koppelman
2011-06-17 15:46   ` martin rudalics
2011-06-19 13:27   ` martin rudalics
2011-06-20 19:17     ` David Koppelman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxhb1aoq.fsf@gmail.com \
    --to=thierry.volpiatto@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).