unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [PATCH] browse-url-mailto
       [not found] <8739bnyw20.fsf@lavabit.com>
@ 2012-01-27 19:00 ` Lars Ingebrigtsen
  2012-01-28  2:48   ` Chong Yidong
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2012-01-27 19:00 UTC (permalink / raw)
  To: Elias Pipping; +Cc: bugs, emacs-devel

Elias Pipping <pipping@lavabit.com> writes:

> clicking a mailto link in an html mail rendered by shr did not work for
> me. The reason appeared to be that the function browse-url-mailto that
> shr.el uses and autoloads does not exist. Instead, the function
> browse-url-mail was probably meant(*).

Thanks; applied.

> (*) The naming is quite confusing: The variable
> browse-url-mailto-function generalises the function
> browse-url-mail. Maybe one of the two should be renamed.

Yeah, that's a less than optimal naming.  Emacs-devel people -- would it
make sense to change `browse-url-mailto-function' to
`browse-url-mail-function'?  The variable was introduced (by, ahem, me)
about a year ago, so it's within the pretest period...

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] browse-url-mailto
  2012-01-27 19:00 ` [PATCH] browse-url-mailto Lars Ingebrigtsen
@ 2012-01-28  2:48   ` Chong Yidong
  2012-01-28 19:05     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2012-01-28  2:48 UTC (permalink / raw)
  To: bugs; +Cc: Elias Pipping, emacs-devel

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> (*) The naming is quite confusing: The variable
>> browse-url-mailto-function generalises the function
>> browse-url-mail. Maybe one of the two should be renamed.
>
> Yeah, that's a less than optimal naming.  Emacs-devel people -- would it
> make sense to change `browse-url-mailto-function' to
> `browse-url-mail-function'?  The variable was introduced (by, ahem, me)
> about a year ago, so it's within the pretest period...

The variable browse-url-mailto-function is used to respond to mailto:
urls.  Its value happens to be browse-url-mail, but I don't think it is
quite correct to say that this variable "generalises" browse-url-mail.

I think the present naming is fine.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] browse-url-mailto
  2012-01-28  2:48   ` Chong Yidong
@ 2012-01-28 19:05     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2012-01-28 19:05 UTC (permalink / raw)
  To: Chong Yidong; +Cc: Elias Pipping, emacs-devel

Chong Yidong <cyd@gnu.org> writes:

> I think the present naming is fine.

Okidoke.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-28 19:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <8739bnyw20.fsf@lavabit.com>
2012-01-27 19:00 ` [PATCH] browse-url-mailto Lars Ingebrigtsen
2012-01-28  2:48   ` Chong Yidong
2012-01-28 19:05     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).