From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: need help with certificate bundles for ALL the platforms Emacs supports
Date: Mon, 13 Feb 2012 11:30:07 -0500 [thread overview]
Message-ID: <87mx8m66i8.fsf@lifelogs.com> (raw)
In-Reply-To: jwvk43qydy2.fsf-monnier+emacs@gnu.org
[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]
On Mon, 13 Feb 2012 10:12:17 -0500 Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
>> Also I don't want to decide the default bundle file names at the time
>> the defcustom is evaluated. Since `gnutls-trustfiles' can contain
>> function calls, I'd like it to be called when it's needed. For
>> instance, it's very common to store certificates as PEM files in a
>> directory, and the user should be able to choose that approach instead
>> of managing a concatenated bundle. If we built the file list only once,
>> the modular approach would fail. Another situation is on W32, where the
>> cert bundle has to be dynamically built (which will require some caching
>> but should still be done as close to using the bundle as possible).
SM> OK, but the variable should not be a "list of (function or filename)".
SM> That's ugly.
I see how it's confusing.
SM> Maybe we can have it be "a function or a list of files".
OK. Patch attached for your review. The code is simpler now and the
list flattening function is not needed.
If approved I think I should also write a manual entry for this new
variable. Should I make a new manual subsection for GnuTLS-related
things? Where?
Now we'll have three customizable variables in gnutls.el
(`gnutls-algorithm-priority', `gnutls-trustfiles', and
`gnutls-min-prime-bits') which is tipping the scales I think. Plus it
will be good to explain what gnutls.el+gnutls.c do and how to debug
problems with them, since most users and developers don't know how
widely they are used in Emacs 24.
Thanks!
Ted
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnutls-trustfiles.patch --]
[-- Type: text/x-diff, Size: 2293 bytes --]
=== modified file 'lisp/net/gnutls.el'
--- lisp/net/gnutls.el 2012-02-12 21:40:25 +0000
+++ lisp/net/gnutls.el 2012-02-13 16:20:13 +0000
@@ -51,6 +51,19 @@
:type '(choice (const nil)
string))
+(defcustom gnutls-trustfiles
+ '(
+ "/etc/ssl/certs/ca-certificates.crt" ; Debian, Ubuntu, Gentoo and Arch Linux
+ "/etc/pki/tls/certs/ca-bundle.crt" ; Fedora and RHEL
+ "/etc/ssl/ca-bundle.pem" ; Suse
+ )
+ "List of CA bundle location filenames or a function returning said list.
+The files may be in PEM or DER format, as per the GnuTLS documentation.
+The files may not exist, in which case they will be ignored."
+ :group 'gnutls
+ :type '(choice (function :tag "Function to produce list of bundle filenames")
+ (repeat (file :tag "Bundle filename"))))
+
;;;###autoload
(defcustom gnutls-min-prime-bits nil
"The minimum number of bits to be used in Diffie-Hellman key exchange.
@@ -118,7 +131,7 @@
PROCESS is a process returned by `open-network-stream'.
HOSTNAME is the remote hostname. It must be a valid string.
PRIORITY-STRING is as per the GnuTLS docs, default is \"NORMAL\".
-TRUSTFILES is a list of CA bundles.
+TRUSTFILES is a list of CA bundles. It defaults to `gnutls-trustfiles'.
CRLFILES is a list of CRL files.
KEYLIST is an alist of (client key file, client cert file) pairs.
MIN-PRIME-BITS is the minimum acceptable size of Diffie-Hellman keys
@@ -156,10 +169,12 @@
It must be omitted, a number, or nil; if omitted or nil it
defaults to GNUTLS_VERIFY_ALLOW_X509_V1_CA_CRT."
(let* ((type (or type 'gnutls-x509pki))
- (default-trustfile "/etc/ssl/certs/ca-certificates.crt")
(trustfiles (or trustfiles
- (when (file-exists-p default-trustfile)
- (list default-trustfile))))
+ (delq nil
+ (mapcar (lambda (f) (and f (file-exists-p f) f))
+ (if (functionp gnutls-trustfiles)
+ (funcall gnutls-trustfiles)
+ gnutls-trustfiles)))))
(priority-string (or priority-string
(cond
((eq type 'gnutls-anon)
next prev parent reply other threads:[~2012-02-13 16:30 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 2:02 Emacs 24.0.93 Pretest Windows Binaries published Christoph Scholtes
2012-01-30 4:55 ` Drew Adams
2012-01-30 17:47 ` Eli Zaretskii
2012-01-30 18:17 ` [h-e-w] " Drew Adams
2012-01-30 18:57 ` Eli Zaretskii
2012-01-30 19:08 ` Drew Adams
2012-01-30 19:09 ` Eli Zaretskii
2012-01-30 18:49 ` Eli Zaretskii
2012-01-31 14:03 ` Christoph Scholtes
2012-01-31 14:15 ` Drew Adams
2012-02-02 19:22 ` Ted Zlatanov
2012-02-02 19:52 ` Drew Adams
2012-02-02 21:46 ` Ted Zlatanov
2012-02-02 22:05 ` Drew Adams
2012-02-03 13:26 ` Ted Zlatanov
2012-02-03 7:48 ` Eli Zaretskii
2012-02-03 13:23 ` GnuTLS invasion of Emacs (was: Emacs 24.0.93 Pretest Windows Binaries published) Ted Zlatanov
2012-02-03 16:29 ` GnuTLS invasion of Emacs published) Eli Zaretskii
2012-02-03 16:51 ` Ted Zlatanov
2012-02-09 14:16 ` need help with certificate bundles for ALL the platforms Emacs supports (was: GnuTLS invasion of Emacs published)) Ted Zlatanov
2012-02-09 18:53 ` Eli Zaretskii
2012-02-10 13:06 ` need help with certificate bundles for ALL the platforms Emacs supports Ted Zlatanov
2012-02-10 15:51 ` Eli Zaretskii
2012-02-10 16:37 ` Ted Zlatanov
2012-02-11 17:22 ` Andy Moreton
2012-02-11 17:45 ` Eli Zaretskii
2012-02-12 2:43 ` Ted Zlatanov
2012-02-12 4:05 ` Eli Zaretskii
2012-02-12 13:36 ` Ted Zlatanov
2012-02-13 10:29 ` Andy Moreton
2012-02-13 13:15 ` Ted Zlatanov
2012-02-10 17:11 ` Ted Zlatanov
2012-02-10 18:57 ` Stefan Monnier
2012-02-12 22:13 ` Ted Zlatanov
2012-02-13 3:28 ` Stefan Monnier
2012-02-13 13:24 ` Ted Zlatanov
2012-02-13 15:12 ` Stefan Monnier
2012-02-13 16:30 ` Ted Zlatanov [this message]
2012-02-13 21:04 ` Stefan Monnier
2012-02-13 21:54 ` Ted Zlatanov
2012-02-13 21:55 ` Lars Ingebrigtsen
2012-02-13 22:20 ` Stefan Monnier
2012-02-14 0:05 ` Ted Zlatanov
2012-02-14 2:13 ` Stefan Monnier
2012-02-14 2:32 ` Glenn Morris
2012-02-14 13:01 ` Ted Zlatanov
2012-02-03 13:25 ` Emacs 24.0.93 Pretest Windows Binaries published Stefan Monnier
2012-02-03 0:48 ` [h-e-w] " Richard M. Heiberger
2012-02-03 8:12 ` Eli Zaretskii
2012-02-03 10:03 ` Stephen J. Turnbull
2012-02-03 10:31 ` Eli Zaretskii
2012-02-03 13:49 ` Stephen J. Turnbull
2012-02-03 15:44 ` Eli Zaretskii
2012-02-12 4:04 ` Lennart Borgman
2012-02-12 4:08 ` Lennart Borgman
2012-02-12 16:23 ` Eli Zaretskii
2012-02-12 22:19 ` Lennart Borgman
2012-02-13 3:29 ` Stefan Monnier
2012-02-13 3:51 ` Eli Zaretskii
2012-02-13 19:23 ` Lennart Borgman
2012-02-14 22:43 ` Lennart Borgman
-- strict thread matches above, loose matches on Subject: below --
2012-02-13 22:30 need help with certificate bundles for ALL the platforms Emacs supports nyc4bos
2012-02-14 13:14 ` Ted Zlatanov
2012-02-14 14:04 ` Andy Moreton
2012-02-14 15:53 ` Ted Zlatanov
2012-02-16 18:47 ` nyc4bos
2012-02-17 13:06 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx8m66i8.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).