* Windows build broken on trunk @ 2012-07-18 8:42 Andy Moreton 2012-07-18 9:55 ` Dmitry Antipov 0 siblings, 1 reply; 12+ messages in thread From: Andy Moreton @ 2012-07-18 8:42 UTC (permalink / raw) To: emacs-devel Hi, Bootstrapping trunk on Windows (mingw32 GCC 4.6.1) failed this morning: w32font.c:78:40: error: static declaration of 'Qsymbol' follows non-static declaration lisp.h:2335:41: note: previous declaration of 'Qsymbol' was here mingw32-make[3]: *** [oo/i386/w32font.o] Error 1 mingw32-make[3]: Leaving directory `C:/emacs/src/emacs/trunk/src' This appers to be from r109131 committed by Dmitry Antipov. I'm not familiar with the code: is the static Qsymbol used in w32font.c referring to some aspect of font handling, or is it the same thing as the global that was added to src/lisp.h ? AndyM ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-18 8:42 Windows build broken on trunk Andy Moreton @ 2012-07-18 9:55 ` Dmitry Antipov 2012-07-18 10:10 ` Andreas Schwab 0 siblings, 1 reply; 12+ messages in thread From: Dmitry Antipov @ 2012-07-18 9:55 UTC (permalink / raw) To: Andy Moreton; +Cc: emacs-devel On 07/18/2012 12:42 PM, Andy Moreton wrote: > Bootstrapping trunk on Windows (mingw32 GCC 4.6.1) failed this morning: > > w32font.c:78:40: error: static declaration of 'Qsymbol' follows non-static declaration > lisp.h:2335:41: note: previous declaration of 'Qsymbol' was here > mingw32-make[3]: *** [oo/i386/w32font.o] Error 1 > mingw32-make[3]: Leaving directory `C:/emacs/src/emacs/trunk/src' > > This appers to be from r109131 committed by Dmitry Antipov. > > I'm not familiar with the code: is the static Qsymbol used in w32font.c > referring to some aspect of font handling, or is it the same thing as the > global that was added to src/lisp.h ? IIUC it's font handling stuff, and (IMHO) it should be renamed from too generic name to something which is closely related to symbol's real use. Dmitry ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-18 9:55 ` Dmitry Antipov @ 2012-07-18 10:10 ` Andreas Schwab 2012-07-18 12:23 ` Andy Moreton 0 siblings, 1 reply; 12+ messages in thread From: Andreas Schwab @ 2012-07-18 10:10 UTC (permalink / raw) To: Dmitry Antipov; +Cc: Andy Moreton, emacs-devel Dmitry Antipov <dmantipov@yandex.ru> writes: > IIUC it's font handling stuff, and (IMHO) it should be renamed from too > generic name to something which is closely related to symbol's real use. The symbol's real use is the Lisp symbol symbol. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-18 10:10 ` Andreas Schwab @ 2012-07-18 12:23 ` Andy Moreton 2012-07-18 12:37 ` Andreas Schwab 2012-07-18 13:38 ` Jason Rumney 0 siblings, 2 replies; 12+ messages in thread From: Andy Moreton @ 2012-07-18 12:23 UTC (permalink / raw) To: emacs-devel On Wed 18 Jul 2012, Andreas Schwab wrote: > Dmitry Antipov <dmantipov@yandex.ru> writes: > >> IIUC it's font handling stuff, and (IMHO) it should be renamed from too >> generic name to something which is closely related to symbol's real use. > > The symbol's real use is the Lisp symbol symbol. > > Andreas. I think you are incorrect on this point. The manual has this in node "Windows Fonts": `script' Specifies a Unicode subrange the font should support. The following scripts are recognized on Windows: `latin', `greek', `coptic', `cyrillic', `armenian', `hebrew', `arabic', `syriac', `nko', `thaana', `devanagari', `bengali', `gurmukhi', `gujarati', `oriya', `tamil', `telugu', `kannada', `malayam', `sinhala', `thai', `lao', `tibetan', `myanmar', `georgian', `hangul', `ethiopic', `cherokee', `canadian-aboriginal', `ogham', `runic', `khmer', `mongolian', `symbol', `braille', `han', `ideographic-description', `cjk-misc', `kana', `bopomofo', `kanbun', `yi', `byzantine-musical-symbol', `musical-symbol', and `mathematical'. From src/w32font.c, line 79: static Lisp_Object Qkhmer, Qmongolian, Qsymbol, Qbraille, Qhan; This Qsymbol is used for the script property, and is distinct from the Lisp symbol symbol used in the rest of emacs. The name clash is unfortunate. AndyM ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-18 12:23 ` Andy Moreton @ 2012-07-18 12:37 ` Andreas Schwab 2012-07-18 13:38 ` Jason Rumney 1 sibling, 0 replies; 12+ messages in thread From: Andreas Schwab @ 2012-07-18 12:37 UTC (permalink / raw) To: Andy Moreton; +Cc: emacs-devel Andy Moreton <andrewjmoreton@gmail.com> writes: > This Qsymbol is used for the script property, and is distinct from the > Lisp symbol symbol used in the rest of emacs. Interned Lisp symbols are globally unique. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-18 12:23 ` Andy Moreton 2012-07-18 12:37 ` Andreas Schwab @ 2012-07-18 13:38 ` Jason Rumney 2012-07-19 7:05 ` Stefan Monnier 1 sibling, 1 reply; 12+ messages in thread From: Jason Rumney @ 2012-07-18 13:38 UTC (permalink / raw) To: Andy Moreton; +Cc: emacs-devel Andy Moreton <andrewjmoreton@gmail.com> writes: > This Qsymbol is used for the script property, and is distinct from the > Lisp symbol symbol used in the rest of emacs. > > The name clash is unfortunate. The name clash is inconsequential. The static definition in w32font.c can be removed if symbol is now globally defined. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-18 13:38 ` Jason Rumney @ 2012-07-19 7:05 ` Stefan Monnier 2012-07-19 16:22 ` Samuel Bronson 2012-07-20 7:52 ` Andreas Schwab 0 siblings, 2 replies; 12+ messages in thread From: Stefan Monnier @ 2012-07-19 7:05 UTC (permalink / raw) To: Jason Rumney; +Cc: Andy Moreton, emacs-devel > The name clash is inconsequential. The static definition in w32font.c > can be removed if symbol is now globally defined. The "Lisp_Object Q<foo>" declarations should be auto-generated in globals.h from the DEFSYM calls, IMNSHO. Stefan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-19 7:05 ` Stefan Monnier @ 2012-07-19 16:22 ` Samuel Bronson 2012-07-19 22:49 ` Stefan Monnier 2012-07-20 7:52 ` Andreas Schwab 1 sibling, 1 reply; 12+ messages in thread From: Samuel Bronson @ 2012-07-19 16:22 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel, Andy Moreton, Jason Rumney On Jul 19, 2012, at 3:05 AM, Stefan Monnier wrote: >> The name clash is inconsequential. The static definition in >> w32font.c >> can be removed if symbol is now globally defined. > > The "Lisp_Object Q<foo>" declarations should be auto-generated in > globals.h from the DEFSYM calls, IMNSHO. Isn't that a bit excessive? ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-19 16:22 ` Samuel Bronson @ 2012-07-19 22:49 ` Stefan Monnier 0 siblings, 0 replies; 12+ messages in thread From: Stefan Monnier @ 2012-07-19 22:49 UTC (permalink / raw) To: Samuel Bronson; +Cc: emacs-devel, Andy Moreton, Jason Rumney >>> The name clash is inconsequential. The static definition in w32font.c >>> can be removed if symbol is now globally defined. >> The "Lisp_Object Q<foo>" declarations should be auto-generated in >> globals.h from the DEFSYM calls, IMNSHO. > Isn't that a bit excessive? Why? Stefan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-19 7:05 ` Stefan Monnier 2012-07-19 16:22 ` Samuel Bronson @ 2012-07-20 7:52 ` Andreas Schwab 2012-07-20 9:30 ` Stephen J. Turnbull 2012-07-20 9:55 ` Stefan Monnier 1 sibling, 2 replies; 12+ messages in thread From: Andreas Schwab @ 2012-07-20 7:52 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel, Andy Moreton, Jason Rumney Stefan Monnier <monnier@IRO.UMontreal.CA> writes: >> The name clash is inconsequential. The static definition in w32font.c >> can be removed if symbol is now globally defined. > > The "Lisp_Object Q<foo>" declarations should be auto-generated in > globals.h from the DEFSYM calls, IMNSHO. Those are definitions, not declarations, so they cannot go to globals.h. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-20 7:52 ` Andreas Schwab @ 2012-07-20 9:30 ` Stephen J. Turnbull 2012-07-20 9:55 ` Stefan Monnier 1 sibling, 0 replies; 12+ messages in thread From: Stephen J. Turnbull @ 2012-07-20 9:30 UTC (permalink / raw) To: Andreas Schwab; +Cc: Jason Rumney, Andy Moreton, Stefan Monnier, emacs-devel Andreas Schwab writes: > Stefan Monnier <monnier@IRO.UMontreal.CA> writes: > > >> The name clash is inconsequential. The static definition in w32font.c > >> can be removed if symbol is now globally defined. > > > > The "Lisp_Object Q<foo>" declarations should be auto-generated in > > globals.h from the DEFSYM calls, IMNSHO. > > Those are definitions, not declarations, so they cannot go to globals.h. Doesn't matter, they are data, *not* code, for Stefan's application. In-best-Andreas-Schwab-style-ly y'rs, ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Windows build broken on trunk 2012-07-20 7:52 ` Andreas Schwab 2012-07-20 9:30 ` Stephen J. Turnbull @ 2012-07-20 9:55 ` Stefan Monnier 1 sibling, 0 replies; 12+ messages in thread From: Stefan Monnier @ 2012-07-20 9:55 UTC (permalink / raw) To: Andreas Schwab; +Cc: emacs-devel, Andy Moreton, Jason Rumney >>> The name clash is inconsequential. The static definition in w32font.c >>> can be removed if symbol is now globally defined. >> The "Lisp_Object Q<foo>" declarations should be auto-generated in >> globals.h from the DEFSYM calls, IMNSHO. > Those are definitions, not declarations, so they cannot go to globals.h. Duh, you're right. Stefan ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-07-20 9:55 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-18 8:42 Windows build broken on trunk Andy Moreton 2012-07-18 9:55 ` Dmitry Antipov 2012-07-18 10:10 ` Andreas Schwab 2012-07-18 12:23 ` Andy Moreton 2012-07-18 12:37 ` Andreas Schwab 2012-07-18 13:38 ` Jason Rumney 2012-07-19 7:05 ` Stefan Monnier 2012-07-19 16:22 ` Samuel Bronson 2012-07-19 22:49 ` Stefan Monnier 2012-07-20 7:52 ` Andreas Schwab 2012-07-20 9:30 ` Stephen J. Turnbull 2012-07-20 9:55 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).