From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: button-buffer-map should inherit from special-mode-map Date: Thu, 21 Feb 2013 13:42:16 -0500 Message-ID: <87mwuxse47.fsf@gnu.org> References: <87y5ehsimf.fsf@gnu.org> <64BBBA8150564874B08184FC5A733196@us.oracle.com> Reply-To: sds@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1361472162 32443 80.91.229.3 (21 Feb 2013 18:42:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Feb 2013 18:42:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 21 19:43:04 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U8b6k-0005XR-Sa for ged-emacs-devel@m.gmane.org; Thu, 21 Feb 2013 19:43:02 +0100 Original-Received: from localhost ([::1]:41544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8b6Q-0005Kl-HB for ged-emacs-devel@m.gmane.org; Thu, 21 Feb 2013 13:42:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8b6I-0005Kf-AZ for emacs-devel@gnu.org; Thu, 21 Feb 2013 13:42:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8b6B-0005pW-H5 for emacs-devel@gnu.org; Thu, 21 Feb 2013 13:42:34 -0500 Original-Received: from mail-vc0-f177.google.com ([209.85.220.177]:36559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8b67-0005mF-FN; Thu, 21 Feb 2013 13:42:23 -0500 Original-Received: by mail-vc0-f177.google.com with SMTP id m18so5954456vcm.22 for ; Thu, 21 Feb 2013 10:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:in-reply-to:references :user-agent:return-receipt-to:reply-to:x-attribution:x-disclaimer :date:message-id:mime-version:content-type; bh=dDqpzwZKAOwErLMVZr/AEK8uMKZE3VRx406OHP4pO/g=; b=s8rvQtjbt3HZpFW6b2Tfg79YdNpTt4ftFbz+WAXdwtiwUtMCxO8ra9htGFiO4mX381 RJ0CPiyBNV18IgymgrCIaC5VGwtlJvbZf/UHY0vuwwQkGxdnnlInir1iBBqgwb9t1Q9W umMN+xV7/KmM7gblTXO2lvwmrskhVgDuNxE74mwwcN7PfzVFBrNV/gqQ/e8z13AiG+kJ o7ogykzNyfXV6dfDptso3vY2EfFAfUMIi4fky5w4Tdld8XSz1Al/f1SKupMr447qs8Vt I3k4rAHjnIbnsjpwsuT7lsHLQ0n3g26i8/uOeNT0Em/hv6wajktiItGoGsoSKGfNEMsp tBiQ== X-Received: by 10.220.228.74 with SMTP id jd10mr32122979vcb.65.1361472142050; Thu, 21 Feb 2013 10:42:22 -0800 (PST) Original-Received: from t520sds ([74.113.160.197]) by mx.google.com with ESMTPS id a19sm115513067vdh.9.2013.02.21.10.42.19 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 21 Feb 2013 10:42:20 -0800 (PST) In-Reply-To: <64BBBA8150564874B08184FC5A733196@us.oracle.com> (Drew Adams's message of "Thu, 21 Feb 2013 10:29:49 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.220.177 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157240 Archived-At: > * Drew Adams [2013-02-21 10:29:49 -0800]: > >> IMO, button-buffer-map should inherit from special-mode-map because >> whenever it is used, the map which inherits from it is immediately >> subject to suppress-keymap. If button-buffer-map inherits from >> special-mode-map, then this is done automatically, and, >> additionally, some useful bindings are inherited. >> >> I will commit a patch to this effect unless someone objects. > > Why assume that the characteristics of `special-mode-map' (e.g. keys) > are appropriate for all uses of `button-buffer-map'? Because special-mode-map is supposed to be appropriate for any non-self-insert buffer, and button-buffer-map is only used in such buffers, so, whenever a map inherits from button-buffer-map but not special-mode-map, it can be assumed to be an oversight. > Different libraries use `button-mode-map' differently. E.g. `apropos-mode-map' > is a _copy_ of `button-mode-map' and it has `special-mode-map' as its parent. > And `help-mode-map' has as its parent a keymap composed from `button-buffer-map' > and `special-mode-map'. These look like workarounds for the bug of button-buffer-map not inheriting from special-mode-map. > What's really gained by this additional coupling? Simplicity and clarity of code and intent. -- Sam Steingold (http://sds.podval.org/) on Ubuntu 12.04 (precise) X 11.0.11103000 http://www.childpsy.net/ http://jihadwatch.org http://truepeace.org http://www.memritv.org http://camera.org http://thereligionofpeace.com Why use Windows, when there are Doors?