From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests! Date: Mon, 11 Mar 2013 20:01:57 -0600 Message-ID: <87mwu9l6ju.fsf@fleche.redhat.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1363054397 24628 80.91.229.3 (12 Mar 2013 02:13:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Mar 2013 02:13:17 +0000 (UTC) Cc: Emacs development discussions To: Daniel Hackney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 03:13:42 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFEii-0004fg-0K for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2013 03:13:40 +0100 Original-Received: from localhost ([::1]:34082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFEiL-0002cT-9P for ged-emacs-devel@m.gmane.org; Mon, 11 Mar 2013 22:13:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFEiI-0002Yf-3E for emacs-devel@gnu.org; Mon, 11 Mar 2013 22:13:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFEiE-00077q-7p for emacs-devel@gnu.org; Mon, 11 Mar 2013 22:13:14 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:34605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFEXQ-00049R-Qx for emacs-devel@gnu.org; Mon, 11 Mar 2013 22:02:00 -0400 Original-Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2C21xaS023477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Mar 2013 22:01:59 -0400 Original-Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2C21vnm021352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 11 Mar 2013 22:01:58 -0400 X-Attribution: Tom In-Reply-To: (Daniel Hackney's message of "Mon, 11 Mar 2013 21:03:25 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157755 Archived-At: Daniel> My aim has been to clean up package.el, primarily by using Daniel> `cl-defstruct' to create a `package-desc' structure which is Daniel> used throughout the library. This sounds good. Daniel> The changes touch most of the code, but the overall structure of the Daniel> code has not changed significantly. Some parts of the code which were Daniel> questionable in the first place (such as using `tar-mode' to extract tar Daniel> archives) have been replaced with simpler alternatives. In the case of Daniel> tar, the file is simply downloaded to a temporary directory and Daniel> extracted using "tar xaf foo-1.2.3.tar". This sounds worse to me, since it means that now package installation has an external dependency. Previously this was not the case -- intentionally. Tom