From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: missing quote in define-package arg Date: Sat, 24 May 2014 16:42:54 +0200 Message-ID: <87mwe7grv5.fsf@zigzag.favinet> References: <8738fzir0e.fsf@zigzag.favinet> <87vbsvhadu.fsf@zigzag.favinet> <87zji7wgwt.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1400942407 21683 80.91.229.3 (24 May 2014 14:40:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 May 2014 14:40:07 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 24 16:40:02 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WoD7B-0003T3-Sg for ged-emacs-devel@m.gmane.org; Sat, 24 May 2014 16:40:01 +0200 Original-Received: from localhost ([::1]:48196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoD7B-0002It-Hz for ged-emacs-devel@m.gmane.org; Sat, 24 May 2014 10:40:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoD73-0002Cj-LC for emacs-devel@gnu.org; Sat, 24 May 2014 10:39:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoD6y-00038A-7A for emacs-devel@gnu.org; Sat, 24 May 2014 10:39:53 -0400 Original-Received: from smtp207.alice.it ([82.57.200.103]:56184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoD6x-00035t-Rg for emacs-devel@gnu.org; Sat, 24 May 2014 10:39:48 -0400 Original-Received: from zigzag.favinet (79.51.75.160) by smtp207.alice.it (8.6.060.28) id 525156852D076242 for emacs-devel@gnu.org; Sat, 24 May 2014 16:39:46 +0200 Original-Received: from ttn by zigzag.favinet with local (Exim 4.80) (envelope-from ) id 1WoDA9-0008Uj-Mw for emacs-devel@gnu.org; Sat, 24 May 2014 16:43:05 +0200 Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <87zji7wgwt.fsf@yandex.ru> (Dmitry Gutov's message of "Sat, 24 May 2014 14:32:50 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 82.57.200.103 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172062 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable () Dmitry Gutov () Sat, 24 May 2014 14:32:50 +0300 Not exactly unnoticed (https://github.com/milkypostman/melpa/pull/1619#issuecomment-39480891, https://github.com/milkypostman/melpa/issues/1669), but it's a minor issue that has no bearing on functionality. Agreed, if by functionality, we limit ourselves to the package in question. Whether or not it is minor, it should be fixed, anyway... I believe it can be fixed in two ways: by adding quoting where it was missed (like you're suggesting), or by excluding -pkg.el files from byte-compilation. The second way is not a fix, for it leaves manifest a syntax error, on disk (and maybe later, in memory -- i admit i haven't yet looked closely at package.el to know its design). It's not a bad idea per se, however, since it seems there is little gain from byte-compiling -pkg.el files. I am presently reading the BzrForEmacsDevs page on the EmacsWiki (while waiting for bzr-initiated bits to percolate my way through the net), and hope to install a fix, as well as the simplification you suggest, shortly. =2D-=20 Thien-Thi Nguyen GPG key: 4C807502 (if you're human and you know it) read my lisp: (responsep (questions 'technical) (not (via 'mailing-list))) =3D> nil --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlOAr/IACgkQZwMiJEyAdQKdyACffWv6aXVd8qdpGjsOdMxwExuR +QoAn1DcBfIXQiDIO21iFkpB3ExQ2n+J =2+J7 -----END PGP SIGNATURE----- --=-=-=--