unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thien-Thi Nguyen <ttn@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: missing quote in define-package arg
Date: Sat, 24 May 2014 16:42:54 +0200	[thread overview]
Message-ID: <87mwe7grv5.fsf@zigzag.favinet> (raw)
In-Reply-To: <87zji7wgwt.fsf@yandex.ru> (Dmitry Gutov's message of "Sat, 24 May 2014 14:32:50 +0300")

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

() Dmitry Gutov <dgutov@yandex.ru>
() Sat, 24 May 2014 14:32:50 +0300

   Not exactly unnoticed
   (https://github.com/milkypostman/melpa/pull/1619#issuecomment-39480891,
   https://github.com/milkypostman/melpa/issues/1669), but it's a minor
   issue that has no bearing on functionality.

Agreed, if by functionality, we limit ourselves to the package in
question.  Whether or not it is minor, it should be fixed, anyway...

   I believe it can be fixed in two ways: by adding quoting where it was
   missed (like you're suggesting), or by excluding -pkg.el files from
   byte-compilation.

The second way is not a fix, for it leaves manifest a syntax error, on
disk (and maybe later, in memory -- i admit i haven't yet looked closely
at package.el to know its design).  It's not a bad idea per se, however,
since it seems there is little gain from byte-compiling -pkg.el files.

I am presently reading the BzrForEmacsDevs page on the EmacsWiki (while
waiting for bzr-initiated bits to percolate my way through the net), and
hope to install a fix, as well as the simplification you suggest, shortly.

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2014-05-24 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-24  7:18 missing quote in define-package arg Thien-Thi Nguyen
2014-05-24  8:02 ` Thien-Thi Nguyen
2014-05-24 11:32   ` Dmitry Gutov
2014-05-24 14:42     ` Thien-Thi Nguyen [this message]
2014-05-24 19:57       ` Dmitry Gutov
2014-05-25  7:53         ` Thien-Thi Nguyen
2014-05-25 17:05       ` Thien-Thi Nguyen
2014-05-26  0:19         ` Stephen J. Turnbull
2014-05-26  9:15           ` Thien-Thi Nguyen
2014-05-27 19:23         ` chad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwe7grv5.fsf@zigzag.favinet \
    --to=ttn@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).