From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Subject: Recent stat from coreutils could break Tramp
Date: Thu, 05 May 2016 10:43:14 +0200 [thread overview]
Message-ID: <87mvo499p9.fsf@gmx.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
Hi,
I've just installed the appended patch to the master branch as
6aad36ace9953b9672b13be68416d205532d5e59. The problem is, that the stat
program has changed its output format; it will break Tramp for some
special characters in file names. It's a pity that this has been shown
such late; it came to me after upgrading my development machine to
Ubuntu 16.04.
I've reported the problem to the coreutils maintainers as bug#23422, and
they promised to fix it. However, the current tramp-tests.el reports a
failed test.
The fix is very simple. Shall I backport (cherrypick) it also to the
emacs-25 branch?
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1370 bytes --]
*** /usr/local/src/emacs/lisp/net/tramp-sh.el.~6e790b71efae6003b9fa701a8630ee69e0a94294~ 2016-05-05 10:40:11.455293200 +0200
--- /usr/local/src/emacs/lisp/net/tramp-sh.el 2016-05-05 10:19:50.567195614 +0200
***************
*** 5430,5442 ****
vec "stat" (tramp-get-remote-path vec)))
tmp)
;; Check whether stat(1) returns usable syntax. "%s" does not
! ;; work on older AIX systems.
(when result
(setq tmp
(tramp-send-command-and-read
vec (format "%s -c '(\"%%N\" %%s)' /" result) 'noerror))
(unless (and (listp tmp) (stringp (car tmp))
! (string-match "^./.$" (car tmp))
(integerp (cadr tmp)))
(setq result nil)))
result)))
--- 5430,5444 ----
vec "stat" (tramp-get-remote-path vec)))
tmp)
;; Check whether stat(1) returns usable syntax. "%s" does not
! ;; work on older AIX systems. Recent GNU stat versions (8.24?)
! ;; use shell quoted format for "%N", we check the boundaries "`"
! ;; and "'", therefore. See Bug#23422 in coreutils.
(when result
(setq tmp
(tramp-send-command-and-read
vec (format "%s -c '(\"%%N\" %%s)' /" result) 'noerror))
(unless (and (listp tmp) (stringp (car tmp))
! (string-match "^`/'$" (car tmp))
(integerp (cadr tmp)))
(setq result nil)))
result)))
next reply other threads:[~2016-05-05 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 8:43 Michael Albinus [this message]
2016-05-05 17:51 ` Recent stat from coreutils could break Tramp John Wiegley
2016-05-06 6:20 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvo499p9.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).