unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Politz <politza@hochschule-trier.de>
To: Ken Brown <kbrown@cornell.edu>
Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch'
Date: Wed, 05 Apr 2017 23:02:33 +0200	[thread overview]
Message-ID: <87mvbutvo6.fsf@luca> (raw)
In-Reply-To: <70055ee8-c1cb-30d2-8a0b-38637adad497@cornell.edu> (Ken Brown's message of "Tue, 4 Apr 2017 18:36:21 -0400")

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Ken Brown <kbrown@cornell.edu> writes:

> This may be another of those timing issues that we've dealt with
> before [...].

I think it is as well.  If cygwin's file-notify back-end runs on a polling
timer, we need to make sure that it has acknowledged the file's
existence before we delete it.  Maybe you could try out the following
patch.


[-- Attachment #2: Type: text/plain, Size: 561 bytes --]

diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
index 54e7ebfc0e..9b5c751021 100644
--- a/test/lisp/filenotify-tests.el
+++ b/test/lisp/filenotify-tests.el
@@ -425,6 +425,7 @@ file-notify--test-make-temp-name
                   '(change) #'second-callback)))
           ;; Remove first watch.
           (file-notify-rm-watch file-notify--test-desc)
+          (file-notify--test-read-event)
           ;; Only the second callback shall run.
           (delete-file file-notify--test-tmpfile)
           (file-notify--wait-for-events

[-- Attachment #3: Type: text/plain, Size: 5 bytes --]


-ap

  parent reply	other threads:[~2017-04-05 21:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170322131610.22658.57119@vcs0.savannah.gnu.org>
     [not found] ` <20170322131611.5FF7D20E17@vcs0.savannah.gnu.org>
2017-04-04 22:36   ` [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch' Ken Brown
2017-04-05  6:58     ` Michael Albinus
2017-04-05 19:24       ` Ken Brown
2017-04-05 21:02     ` Andreas Politz [this message]
2017-04-06  2:59       ` Ken Brown
2017-04-07 14:56         ` Ken Brown
2017-05-01 10:21           ` Michael Albinus
2017-05-01 18:28             ` Ken Brown
2017-05-01 18:45               ` Michael Albinus
2017-05-08 13:28                 ` Ken Brown
2017-05-08 15:30                   ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvbutvo6.fsf@luca \
    --to=politza@hochschule-trier.de \
    --cc=emacs-devel@gnu.org \
    --cc=kbrown@cornell.edu \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).